Skip to content

[bsp_server] lower version flags to 17 in scip_const.py#18

Merged
JamyDev merged 3 commits intouber:mainfrom
murray-stripe:murray/remaining-java21-fixes
Sep 8, 2025
Merged

[bsp_server] lower version flags to 17 in scip_const.py#18
JamyDev merged 3 commits intouber:mainfrom
murray-stripe:murray/remaining-java21-fixes

Conversation

@murray-stripe
Copy link
Copy Markdown
Contributor

@murray-stripe murray-stripe commented Sep 5, 2025

Description

A follow-up to #13. This PR changes the Java language level flags defined in scip_const.py (as part of the bsp_server) from 21 to 17, to remain consistent with the values defined in .bazelrc.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test improvement

Component(s) Affected

  • Language Server (ULSP)
  • SCIP Generation (Python utilities)
  • VS Code/Cursor Extension
  • Java Aggregator
  • Build System (Bazel)
  • Documentation
  • Tests

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (bazel test //...) (**see comment)
  • I have tested this manually with a real project

Manual Testing Details

Describe how you tested these changes:

  • IDE used for testing: VS Code
  • Project(s) tested against: Internal company project
  • Specific features/scenarios verified: run scip_sync.py both for a "full" sync an an incremental sync.

Checklist

  • My code follows the existing code style and conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated BUILD.bazel files if I added new source files
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots/Logs (if applicable)

Include any relevant screenshots, logs, or output that demonstrates the changes.

Related Issues

Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)

Additional Notes

Any additional information that reviewers should know about this PR.

@murray-stripe
Copy link
Copy Markdown
Contributor Author

Noticed a couple of things here regarding the tests for bsp_server.

  1. The tests do not run as part of the github CI workflow, we just run bazel test //src/...
  2. The tests do not all pass (on main)
  3. I made a change to get one of the tests to pass since it was sort-of related to my changes.
  4. There remains one failing test that seems to be expecting a test repo? Maybe this was missed when pulling this into the open-source version and could be rectified.

py_test(
name = "test_scip_utils",
srcs = glob(["test/test_scip_utils.py"]),
srcs = ["test/test_scip_utils.py"],
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little cleanup since the glob isn't really needed here.

@JamyDev JamyDev merged commit 511969c into uber:main Sep 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants