Skip to content

[bsp_server] lower version flags to 17 in scip_const.py #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamyDev merged 3 commits into from
Sep 8, 2025
Merged

[bsp_server] lower version flags to 17 in scip_const.py #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d37bd79
lower version flags to 17
murray-stripe Sep 5, 2025
12fd400
fix bsp_server tests
murray-stripe Sep 5, 2025
a880d23
remove useless glob
murray-stripe Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bsp_server/scip_sync_util/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ py_library(

py_test(
name = "test_scip_utils",
srcs = glob(["test/test_scip_utils.py"]),
srcs = ["test/test_scip_utils.py"],
Copy link
Copy Markdown
Contributor Author

@murray-stripe murray-stripe Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little cleanup since the glob isn't really needed here.

deps = [
":scip_sync_util",
],
Expand Down
8 changes: 4 additions & 4 deletions bsp_server/scip_sync_util/scip_const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
WORKSPACE_FILE_NAME = "workspace.json"

JAVA_VERSION_FLAGS = [
"--java_language_version=21",
"--java_runtime_version=remotejdk_21",
"--tool_java_language_version=21",
"--tool_java_runtime_version=remotejdk_21",
"--java_language_version=17",
"--java_runtime_version=remotejdk_17",
"--tool_java_language_version=17",
"--tool_java_runtime_version=remotejdk_17",
]


Expand Down
2 changes: 2 additions & 0 deletions bsp_server/scip_sync_util/test/test_scip_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ def test_scip_sync(self, m_output, m_write_list, m_tempfile):
BUILD,
scip_const.SCIP_TOOLING_TARGET,
"--keep_going",
*scip_const.JAVA_VERSION_FLAGS,
]
expected_cmd = [
BAZEL,
Expand All @@ -461,6 +462,7 @@ def test_scip_sync(self, m_output, m_write_list, m_tempfile):
"--aspects",
scip_const.ASPECT_SCIP_INDEX,
scip_const.ASPECT_OUTPUT_GROUPS,
*scip_const.JAVA_VERSION_FLAGS,
]
m_output.assert_has_calls(
[
Expand Down
Loading