Merged
Conversation
3v1n0
reviewed
Apr 28, 2025
Contributor
|
@nteodosio It's also possible to remove geocode and libweather parts. Also, a good thing would be to add the _BUILD_FOR piece in the environment variables to avoid warnings from snapcraft. |
Contributor
Author
|
I confirmed the snap builds fine with the candidate's SDK. The build test will inevitably fail until it is promoted to stable. |
Contributor
|
@nteodosio I think that we can safely add the -dev .debs to allow this to build. It doesn't matter that the SDK will include them in the future. @aleasto what do you think? |
Contributor
Author
|
As long as it is guaranteed to be lower or equal version to what's in the gnome runtime, and we don't stage the library here, it's OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built fine for ARM and x64: https://launchpad.net/~nteodosio/+snap/gnome-contacts.