Add missing -dev files#313
Merged
sergio-costas merged 4 commits intoubuntu:gnome-46-2404-sdkfrom Jun 10, 2025
Merged
Conversation
Some packages are added to the stage, but not their corresponding development packages. This patch fixes this.
Contributor
Author
|
Tested with: |
nteodosio
approved these changes
Jun 6, 2025
Contributor
nteodosio
left a comment
nteodosio
left a comment
There was a problem hiding this comment.
It's good, but why we are listing both the library without -dev and with -dev, given that the latter depends on the former? Will Snapcraft only stage stuff explictly present in this list?
Contributor
Author
You are right. I'll fix it. |
aleasto
reviewed
Jun 6, 2025
The unneeded packages are those that already install the -dev, so the "normal" one should not be needed.
Some -dev packages seem to not force installation of the corresponding library package, so they must be selected manually.
Contributor
Author
|
@nteodosio @3v1n0 I sorted all the -dev packages and removed the "duplicated ones" (this is, those runtime packages which already had the corresponding devel packages), and the result was several soft links missing. That's why I added the required ones again... |
Contributor
|
So it look like Snapcraft indeed only considers staging what is in the package list. I'd suggest putting a comment with your findings. But good to go anyways for me. |
Contributor
Author
That's a good point, indeed. Give me a second... |
Contributor
Author
|
@nteodosio Ok, I found why... those packages are already in Core24. That's why it doesn't install them. So... maybe we can remove them without problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some packages are added to the stage, but not their corresponding development packages. This patch fixes this.
Should solve ubuntu/gnome-contacts#9