Merged
Conversation
cpaelzer
requested review from
athos-ribeiro,
bdrung,
julian-klode,
lvoytek,
rkratky,
s-makin and
utkarsh2102
as code owners
rkratky
requested changes
Feb 12, 2026
Collaborator
rkratky
left a comment
rkratky
left a comment
There was a problem hiding this comment.
@cpaelzer, a few nits and suggestions.
Plus, pursuant to How to contribute docs > File names, could you please rename github-ubuntu.md to ubuntu-on-github.md?
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Co-authored-by: Robert Krátký <robert.kratky@canonical.com>
Per contributors/contribute-docs/#file-names filename and anchor should follow the title of the page. Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
cpaelzer
force-pushed
the
github-access-clarification
branch
from
f695078 to
f7fbf3b
Compare
Collaborator
Author
|
@rkratky applied your suggested changes, followed the ask to rename the file and rebased to latest main - marked you for a re-review |
seb128
approved these changes
Feb 13, 2026
Collaborator
seb128
left a comment
seb128
left a comment
There was a problem hiding this comment.
Thanks, that matches what we discussed
rkratky
approved these changes
Feb 13, 2026
Collaborator
|
Review still needed from any one of @athos-ribeiro, @bdrung, @julian-klode, @lvoytek, and/or @utkarsh2102. Thank you. |
lvoytek
approved these changes
Feb 13, 2026
Collaborator
lvoytek
left a comment
lvoytek
left a comment
There was a problem hiding this comment.
Thanks for this Christian! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handling of gihub.com/ubuntu is not specified at all - let us fix that.
Today the primary admin of that scope is @seb128 who I therefore consider as the primary reviewer.
Since it extends the power of the DMB they are also auto-added.
P.S: If we agree on that there will be a one time action by @seb128 and me to add all existing core-devs.