Support sram depth/width lists, as well as explicit list of legal combos #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for more flexible SRAM depth and width specifications in SRAM generators, specifically targeting TSTECH16C SRAM generators that don't support linear sequences or all combinations of valid depth/width pairs.
- Extends SRAMGroup to support explicit lists of depths/widths and valid triples (depth, width, port) combinations
- Adds new JSON parsing logic to handle "depth list", "width list", and "triples" fields with fallback to existing range-based specifications
- Updates macro compilation logic to use triples when available for generating SRAM macros
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/tapeout/src/main/scala/macros/MacroCompiler.scala | Added logic to handle triples for macro generation with fallback to existing depth/width iteration |
| tools/tapeout/src/main/scala/macrolib/SRAM.scala | Extended SRAMGroup case class and JSON parsing to support explicit lists and triples alongside existing range specifications |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Lux <iansseijelly@berkeley.edu> Co-authored-by: -T.K.233- <chiyufeng@berkeley.edu>"
richardyrh
force-pushed
the
sram-config
branch
from
e19b278 to
b38f520
Compare
iansseijelly
approved these changes
Oct 3, 2025
Contributor
iansseijelly
left a comment
iansseijelly
left a comment
There was a problem hiding this comment.
LGTM. Might be worthy of documenting this new API somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support the TSTECH16C SRAM generators. The depth/widths supported is not a linear sequence; also, some combinations of valid depth and valid width is not valid (thus the triple option). This change should not have any impact on existing SRAM generators, since it looks for the JSON keys
depth list,width list, ortriples.tripleswill take precedence, followed by the explicit lists, and then finally the fallback is the current scheme of specifying 3 numbers (start, end, step). If nothing is found, the compilation fails (like it currently does).Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See
ci:*for full list of labels:ci:fpga-deploy- Run FPGA-based E2E testingci:local-fpga-buildbitstream-deploy- Build local FPGA bitstreams for platforms that are releasedci:disable- Disable CI