Skip to content

Allow ihr to be non-mulitples of 6 in ccpp-physics#3036

Closed
BrianCurtis-NOAA wants to merge 2 commits intoufs-community:developfrom
BrianCurtis-NOAA:feature/gcycle_non6
Closed

Allow ihr to be non-mulitples of 6 in ccpp-physics#3036
BrianCurtis-NOAA wants to merge 2 commits intoufs-community:developfrom
BrianCurtis-NOAA:feature/gcycle_non6

Conversation

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Dec 29, 2025

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

This PR brings in changes to ccpp-physics that allow ihr to be non-mulitples of 6 fixing an issue found in testing for GFS V17.

Commit Message:

* UFSWM - Allow ihr to be non-multiples of 6
  * UFSATM - Allow ihr to be non-multiples of 6
    * ccpp-physics - Allow ihr to be non-multiples of 6

Priority:

  • Critical Bugfix: Reason
  • High: GFSv17 Fixes
  • Normal

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Documentation:

  • Documentation update NOT required.

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator Author

@DavidHuber-NOAA FYI

@BrianCurtis-NOAA BrianCurtis-NOAA added No Baseline Change No Baseline Change Priority: High UFSATM There are changes to the UFSATM repository. CCPP There are changes to a CCPP repository. labels Dec 29, 2025
@BrianCurtis-NOAA BrianCurtis-NOAA marked this pull request as ready for review December 29, 2025 18:06
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Waiting for Reviews (subcomponent) in PRs to Process Dec 30, 2025
@gspetro-NOAA gspetro-NOAA moved this from Waiting for Reviews (subcomponent) to Review in PRs to Process Dec 30, 2025
@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Dec 30, 2025
gspetro-NOAA pushed a commit that referenced this pull request Jan 5, 2026
…; Allow ihr to be non-mulitples of 6 in ccpp-physics (was #3036) (#3030)

* UFSWM - Set IsRestart true only for continue run types; allow ihr to be non-multiples of 6
  * CMEPS - update CMEPS w/ ESCOMP/main
  * UFSATM - Allow ihr to be non-multiples of 6
    * ccpp-physics - Allow ihr to be non-multiples of 6
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Merged via #3030 .

@github-project-automation github-project-automation bot moved this from Schedule to Done in PRs to Process Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCPP There are changes to a CCPP repository. No Baseline Change No Baseline Change Priority: High UFSATM There are changes to the UFSATM repository.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants