Skip to content

Update UPP (2026-01) // Update UFSATM to include ccpp-physics sfcsub cleanup (#3076) // Remove compiler remarks in WW3 subcomponent from debug build (#3081)#3072

Merged
gspetro-NOAA merged 20 commits intoufs-community:developfrom
NickSzapiro-NOAA:upp_202601
Feb 10, 2026
Merged

Update UPP (2026-01) // Update UFSATM to include ccpp-physics sfcsub cleanup (#3076) // Remove compiler remarks in WW3 subcomponent from debug build (#3081)#3072
gspetro-NOAA merged 20 commits intoufs-community:developfrom
NickSzapiro-NOAA:upp_202601

Conversation

@NickSzapiro-NOAA
Copy link
Copy Markdown
Collaborator

@NickSzapiro-NOAA NickSzapiro-NOAA commented Jan 28, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

#3072

Update UPP to top of develop, including EE2 fixes for SWRF, SDEN to reproduce when threading. Bit-for-bit

Note: If combined with other PRs, this PR should only be combined with others that do not change baselines as well

#3076

ccpp-physics hash update for ccpp-physics ufs-community/ccpp-physics#343

#3081

This PR addresses compiler remarks in WW3 subcomponent during debug build. By addressing remark #7712 (“variable has not been used”), unused variables were removed, resulting in cleaner WW3/GFS debug builds.

Commit Message:

* UFSWM - Update UPP, including EE2 fixes; update CCPP
* UFSWM - Remove compiler remarks in debug build
  * UFSATM - Update UPP to top of develop, including EE2 fixes for SWRF, SDEN to reproduce when threading
  * UFSATM - Update CCPP hash for PR 343
    * CCPP - cleanup sfcsub routine
* WW3 - Silence compiler remarks in debug build

Priority:

  • Critical Bugfix: Reason
  • High: Part of EE2 fixes for GFS.v17
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Documentation:

  • Documentation update NOT required.
    • Explanation:

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

dpsarmie
dpsarmie previously approved these changes Jan 29, 2026
@gspetro-NOAA gspetro-NOAA added No Baseline Change No Baseline Change UFSATM There are changes to the UFSATM repository. UPP There are changes to the UPP component repository. labels Jan 29, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Waiting for Reviews (subcomponent) in PRs to Process Jan 29, 2026
@gspetro-NOAA gspetro-NOAA moved this from Waiting for Reviews (subcomponent) to Review in PRs to Process Feb 2, 2026
@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Feb 3, 2026
@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

This PR is next for testing, please go ahead and resync/resolve conflicts, thank you.

@NickSzapiro-NOAA
Copy link
Copy Markdown
Collaborator Author

ok @FernandoAndrade-NOAA , should be sync'd. Please let me know how I can help

@gspetro-NOAA gspetro-NOAA moved this from Schedule to Review in PRs to Process Feb 5, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@NickSzapiro-NOAA Are you willing to combine in PR #3076 here? We'd hoped to put it in with Daniel's PR today, but unfortunately I think we just missed him, as Clara's updates were complete right at 5pm. It seems like this will be the next non-baseline-changing PR to go in tho, and Clara's PR should be ready to combine now.

@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Feb 6, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@NickSzapiro-NOAA Could you combine in #3076 ? Also, what do you think about combining in #3081? All non-baseline-changing.

@NickSzapiro-NOAA
Copy link
Copy Markdown
Collaborator Author

Sure @gspetro-NOAA . #3076 and #3081 have been added here. Please let me know if you'd like me to run pre-test or update PR template

@NickSzapiro-NOAA
Copy link
Copy Markdown
Collaborator Author

NickSzapiro-NOAA commented Feb 6, 2026

@ClaraDraper-NOAA @mingchen-NOAA Please let us know if 1) ok to combine PRs here and 2) yours look ok

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

@ClaraDraper-NOAA @mingchen-NOAA Please let us know if 1) ok to combine PRs here and 2) yours look ok
@NickSzapiro-NOAA I’m good with combining the PRs, and everything looks good to me. Thanks!

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

to note: a security risk in older superlinter forced our hand a bit getting a newer version used in the CI. It can fail for now, but we'll want to work on a PR that adjusts things to pass again.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Note that I am looking into solutions for the doc fail. I think the requirements list or .readthedocs.yaml needs to be updated. However, I think we can merge safely with that failure and fix it in a future PR. There is currently a doc PR open, so I can try to have them put in a fix.

@gspetro-NOAA gspetro-NOAA removed the In Testing The PR that is currently in testing stages label Feb 10, 2026
@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

WW3 is merged: hash 30674e5

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

UFSATM has been merged at 30b6019

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@NickSzapiro-NOAA Please revert .gitmodules and update the hashes for UFSATM and WW3. :)

@NickSzapiro-NOAA
Copy link
Copy Markdown
Collaborator Author

Thanks @gspetro-NOAA and all! Updated. Please let me know if ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCPP There are changes to a CCPP repository. No Baseline Change No Baseline Change Priority: High UFSATM There are changes to the UFSATM repository. UPP There are changes to the UPP component repository. WW3 There are changes to the WW3 component repository.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants