Add paragraph about crescent moon visibility to Hijri docs #7330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Dec 19, 2025
| /// | ||
| /// # Crescent moon visibility | ||
| /// | ||
| /// According to Islam, months begin when an observer first sees the crescent moon. |
Member
There was a problem hiding this comment.
when exactly? the same day? there's something about sunset, no?
Member
There was a problem hiding this comment.
A new moon can basically only occur after sunrise, you cannot see a new moon after sunset.
| /// For centuries, astronomers have been developing criteria for predicting crescent moon | ||
| /// visibility. However, most regions that use the Hijri calendar rely on observations that | ||
| /// are impacted by atmospheric phenomena, meaning such predictions are only an approximation | ||
| /// of ground truth. |
Member
There was a problem hiding this comment.
this calendar is inherently observer-based. everyone can look at the sky and make their own "ground truth", so it's not really ground truth
| /// are impacted by atmospheric phenomena, meaning such predictions are only an approximation | ||
| /// of ground truth. | ||
| /// | ||
| /// The primary exception is Saudi Arabia, where the KACST publishes official predictions of |
Member
There was a problem hiding this comment.
primary exception to what? if it's to "most regions", it should be in that paragraph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #7325