Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions components/calendar/src/cal/hijri.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,18 @@ mod ummalqura_data;
///
/// There are either 6 or 7 30-day months, so the length of the year is 354 or 355 days.
///
/// # Crescent moon visibility
///
/// According to Islam, months begin when an observer first sees the crescent moon.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when exactly? the same day? there's something about sunset, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new moon can basically only occur after sunrise, you cannot see a new moon after sunset.

///
/// For centuries, astronomers have been developing criteria for predicting crescent moon
/// visibility. However, most regions that use the Hijri calendar rely on observations that
/// are impacted by atmospheric phenomena, meaning such predictions are only an approximation
/// of ground truth.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this calendar is inherently observer-based. everyone can look at the sky and make their own "ground truth", so it's not really ground truth

///
/// The primary exception is Saudi Arabia, where the KACST publishes official predictions of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

primary exception to what? if it's to "most regions", it should be in that paragraph

/// crescent timings for multiple centuries. See [`UmmAlQura`].
///
/// # Calendar drift
///
/// As a lunar calendar, this calendar does not intend to follow the solar year, and drifts more
Expand Down