-
Notifications
You must be signed in to change notification settings - Fork 244
Add paragraph about crescent moon visibility to Hijri docs #7330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,6 +57,18 @@ mod ummalqura_data; | |
| /// | ||
| /// There are either 6 or 7 30-day months, so the length of the year is 354 or 355 days. | ||
| /// | ||
| /// # Crescent moon visibility | ||
| /// | ||
| /// According to Islam, months begin when an observer first sees the crescent moon. | ||
| /// | ||
| /// For centuries, astronomers have been developing criteria for predicting crescent moon | ||
| /// visibility. However, most regions that use the Hijri calendar rely on observations that | ||
| /// are impacted by atmospheric phenomena, meaning such predictions are only an approximation | ||
| /// of ground truth. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this calendar is inherently observer-based. everyone can look at the sky and make their own "ground truth", so it's not really ground truth |
||
| /// | ||
| /// The primary exception is Saudi Arabia, where the KACST publishes official predictions of | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. primary exception to what? if it's to "most regions", it should be in that paragraph |
||
| /// crescent timings for multiple centuries. See [`UmmAlQura`]. | ||
| /// | ||
| /// # Calendar drift | ||
| /// | ||
| /// As a lunar calendar, this calendar does not intend to follow the solar year, and drifts more | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when exactly? the same day? there's something about sunset, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new moon can basically only occur after sunrise, you cannot see a new moon after sunset.