Skip to content

six phase motor - inprogress#267

Merged
bhk11 merged 13 commits into
nightlyfrom
Six-Phase-Machines
Apr 30, 2025
Merged

six phase motor - inprogress#267
bhk11 merged 13 commits into
nightlyfrom
Six-Phase-Machines

Conversation

@ranil345
Copy link
Copy Markdown
Collaborator

Development of six phase machines - new feature

@ranil345 ranil345 requested review from XyDrKRulof and bhk11 February 19, 2025 10:14
@ranil345 ranil345 requested a review from max-schenke February 26, 2025 15:16
@ranil345
Copy link
Copy Markdown
Collaborator Author

sixphasePMSM_ode (1).pdf
These are the set of equation i have used for the ode, please let me know in case of anything incorrect

Copy link
Copy Markdown
Member

@max-schenke max-schenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a good first impression!
Please reorder the ODE to make it more easily comprehensible.
I guess we would need to decide which level of generality we / you would like to cover with this model.

Comment thread src/gym_electric_motor/physical_systems/electric_motors/SixPhase_PMSM.py Outdated
Comment thread src/gym_electric_motor/physical_systems/electric_motors/SixPhase_PMSM.py Outdated
Comment thread src/gym_electric_motor/physical_systems/electric_motors/SixPhase_PMSM.py Outdated
Copy link
Copy Markdown
Member

@max-schenke max-schenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your invested time, this is looking very nice already. There are only a few miscellaneous comments I would like you to consider.

Comment thread src/gym_electric_motor/physical_systems/electric_motors/SixPhase_PMSM.py Outdated
Comment thread src/gym_electric_motor/physical_systems/electric_motors/SixPhase_PMSM.py Outdated
Comment thread src/gym_electric_motor/physical_systems/electric_motors/six_phase_motor.py Outdated
@bhk11 bhk11 changed the base branch from master to nightly March 20, 2025 08:43
 Cont-CC-SIXPMSM-v0 environment ready- need critical reviews
@ranil345
Copy link
Copy Markdown
Collaborator Author

ranil345 commented Mar 20, 2025

I have used these calculations to write down the Jacobian, Review on this would be very helpful
jacobian.pdf. Also by the last commit we can now make six phase environment. Now I would like to have your expertise to check whether the environment created really do have the expected features ?
I have also worked on the requested changes . Thank you!

@ranil345 ranil345 marked this pull request as ready for review April 17, 2025 20:02
Copy link
Copy Markdown
Member

@bhk11 bhk11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Copy Markdown
Collaborator

@XyDrKRulof XyDrKRulof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks for all of your efforts :) My last request is to change the doc as noted in my comment

**************

.. math::
\frac{\mathrm{d} i_s^d}{\mathrm{d} t} = \frac{u_s^d + \omega_\mathrm{el} L_s^q i_s^q - R_s i_s^d}{L_s^d} \\
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All instances of d,q,x,y,s have to be non-italic (\mathrm{...})

Also: i_s^d = i_d, L_s^d = L_d, L_s^y = L_y ...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Please look into this commit - 74e04d5

Copy link
Copy Markdown
Collaborator

@XyDrKRulof XyDrKRulof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good to me now. Thanks!

@bhk11 bhk11 merged commit efbbfdd into nightly Apr 30, 2025
6 checks passed
@bhk11 bhk11 deleted the Six-Phase-Machines branch April 30, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants