Skip to content

perf(turbopack): use trace_span in tracing::instrument, improve by 1x #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xusd320 merged 1 commit into from
Dec 30, 2025
Merged

perf(turbopack): use trace_span in tracing::instrument, improve by 1x #2469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/pack-api/src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use pack_core::client::context::{
};
use pack_core::util::convert_to_project_relative;
use qstring::QString;
use tracing::{Instrument, info_span};
use tracing::{Instrument, trace_span};
use turbo_rcstr::{RcStr, rcstr};
use turbo_tasks::{Completion, JoinIterExt, ResolvedVc, TryJoinIterExt, ValueToString, Vc};
use turbo_tasks_fs::File;
Expand Down Expand Up @@ -348,7 +348,7 @@ impl Endpoint for AppEndpoint {

#[turbo_tasks::function]
async fn output(self: Vc<Self>) -> Result<Vc<EndpointOutput>> {
let span = info_span!("app endpoint");
let span = trace_span!("app endpoint");

let asset_context = self.app_module_context();

Expand Down
4 changes: 2 additions & 2 deletions crates/pack-api/src/library.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use pack_core::{
util::convert_to_project_relative,
};
use qstring::QString;
use tracing::{Instrument, info_span};
use tracing::{Instrument, trace_span};
use turbo_rcstr::{RcStr, rcstr};
use turbo_tasks::{Completion, JoinIterExt, ResolvedVc, ValueToString, Vc};
use turbopack::{
Expand Down Expand Up @@ -316,7 +316,7 @@ impl Endpoint for LibraryEndpoint {

#[turbo_tasks::function]
async fn output(self: Vc<Self>) -> Result<Vc<EndpointOutput>> {
let span = info_span!("library endpoint");
let span = trace_span!("library endpoint");
async move {
let this = self.await?;
let output_assets = self.output_assets();
Expand Down
2 changes: 1 addition & 1 deletion crates/pack-api/src/paths.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ pub async fn all_server_paths(
assets: Vc<OutputAssets>,
node_root: Vc<FileSystemPath>,
) -> Result<Vc<ServerPaths>> {
let span = tracing::info_span!("all_server_paths");
let span = tracing::trace_span!("all_server_paths");
Comment thread
xusd320 marked this conversation as resolved.
async move {
let all_assets = all_assets_from_entries(assets).await?;
let node_root = &node_root.await?;
Expand Down
2 changes: 1 addition & 1 deletion crates/pack-api/src/project.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,7 +972,7 @@ impl Project {
self: Vc<Self>,
output_assets: OperationVc<OutputAssets>,
) -> Result<()> {
let span = tracing::info_span!("emitting");
let span = tracing::trace_span!("emitting");

@gemini-code-assist gemini-code-assist Bot Dec 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other files in this PR (e.g., crates/pack-api/src/app.rs), consider importing trace_span at the top of the file and using it directly without the tracing:: prefix. This would make the style for using tracing spans uniform across the codebase.

// at the top of the file
use tracing::{Instrument, trace_span};

// ...

// here
let span = trace_span!("emitting");

async move {
// clean dist director if configured
if self.config().output().await?.clean.is_some_and(|c| c) {
Expand Down
2 changes: 1 addition & 1 deletion crates/pack-core/src/library/chunking_context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ impl ChunkingContext for LibraryChunkingContext {
) -> Result<Vc<ChunkGroupResult>> {
let span = {
let ident = ident.to_string().await?.to_string();
tracing::info_span!("chunking", chunking_type = "evaluated", ident = ident)
tracing::trace_span!("chunking", chunking_type = "evaluated", ident = ident)
Comment thread
xusd320 marked this conversation as resolved.
};
async move {
let entries = chunk_group.entries();
Expand Down
2 changes: 1 addition & 1 deletion next.js
Open in desktop
Submodule next.js updated 72 files
+5 −5 crates/napi/src/next_api/endpoint.rs
+16 −14 crates/napi/src/next_api/project.rs
+5 −5 crates/next-api/src/app.rs
+1 −1 crates/next-api/src/instrumentation.rs
+2 −2 crates/next-api/src/middleware.rs
+10 −10 crates/next-api/src/module_graph.rs
+1 −1 crates/next-api/src/nft_json.rs
+8 −8 crates/next-api/src/pages.rs
+1 −1 crates/next-api/src/paths.rs
+4 −4 crates/next-api/src/project.rs
+1 −1 crates/next-api/src/webpack_stats.rs
+2 −2 crates/next-core/src/app_structure.rs
+2 −1 crates/next-core/src/emit.rs
+3 −3 crates/next-core/src/next_app/app_client_references_chunks.rs
+5 −5 crates/next-core/src/next_client_reference/visit_client_reference.rs
+1 −1 crates/next-core/src/next_manifests/client_reference_manifest.rs
+1 −1 crates/next-core/src/next_shared/transforms/debug_fn_name.rs
+1 −1 crates/next-core/src/next_shared/transforms/modularize_imports.rs
+1 −1 crates/next-core/src/next_shared/transforms/next_cjs_optimizer.rs
+1 −1 crates/next-core/src/next_shared/transforms/next_disallow_re_export_all_in_page.rs
+1 −1 crates/next-core/src/next_shared/transforms/next_dynamic.rs
+1 −1 crates/next-core/src/next_shared/transforms/next_edge_node_api_assert.rs
+1 −1 crates/next-core/src/next_shared/transforms/next_font.rs
+1 −1 crates/next-core/src/next_shared/transforms/next_lint.rs
+1 −1 crates/next-core/src/next_shared/transforms/next_middleware_dynamic_assert.rs
+1 −1 crates/next-core/src/next_shared/transforms/next_optimize_server_react.rs
+1 −1 crates/next-core/src/next_shared/transforms/next_pure.rs
+1 −1 crates/next-core/src/next_shared/transforms/next_react_server_components.rs
+1 −1 crates/next-core/src/next_shared/transforms/next_strip_page_exports.rs
+1 −1 crates/next-core/src/next_shared/transforms/next_track_dynamic_imports.rs
+1 −1 crates/next-core/src/next_shared/transforms/react_remove_properties.rs
+1 −1 crates/next-core/src/next_shared/transforms/remove_console.rs
+1 −1 crates/next-core/src/next_shared/transforms/server_actions.rs
+1 −1 crates/next-core/src/pages_structure.rs
+1 −1 crates/next-core/src/raw_ecmascript_module.rs
+9 −9 crates/next-custom-transforms/src/transforms/server_actions.rs
+2 −2 turbopack/crates/turbo-persistence/src/db.rs
+1 −1 turbopack/crates/turbo-persistence/src/static_sorted_file.rs
+3 −3 turbopack/crates/turbo-tasks-backend/src/backend/mod.rs
+14 −14 turbopack/crates/turbo-tasks-fs/src/lib.rs
+2 −2 turbopack/crates/turbo-tasks-fs/src/watcher.rs
+2 −2 turbopack/crates/turbo-tasks/src/effect.rs
+2 −2 turbopack/crates/turbo-tasks/src/manager.rs
+2 −2 turbopack/crates/turbo-tasks/src/scope.rs
+3 −3 turbopack/crates/turbo-tasks/src/spawn.rs
+2 −2 turbopack/crates/turbopack-browser/src/chunking_context.rs
+2 −2 turbopack/crates/turbopack-cli/src/build/mod.rs
+1 −1 turbopack/crates/turbopack-core/src/chunk/chunking/production.rs
+1 −1 turbopack/crates/turbopack-core/src/chunk/chunking/style_production.rs
+1 −1 turbopack/crates/turbopack-core/src/module_graph/chunk_group_info.rs
+10 −10 turbopack/crates/turbopack-core/src/module_graph/merged_modules.rs
+5 −5 turbopack/crates/turbopack-core/src/module_graph/mod.rs
+1 −1 turbopack/crates/turbopack-core/src/module_graph/module_batches.rs
+2 −2 turbopack/crates/turbopack-core/src/resolve/mod.rs
+1 −1 turbopack/crates/turbopack-css/src/process.rs
+2 −2 turbopack/crates/turbopack-dev-server/src/lib.rs
+1 −1 turbopack/crates/turbopack-ecmascript-plugins/src/transform/directives/client.rs
+1 −1 turbopack/crates/turbopack-ecmascript-plugins/src/transform/emotion.rs
+1 −1 turbopack/crates/turbopack-ecmascript-plugins/src/transform/relay.rs
+1 −1 turbopack/crates/turbopack-ecmascript-plugins/src/transform/styled_components.rs
+1 −1 turbopack/crates/turbopack-ecmascript-plugins/src/transform/styled_jsx.rs
+1 −1 turbopack/crates/turbopack-ecmascript-plugins/src/transform/swc_ecma_transform_plugins.rs
+1 −1 turbopack/crates/turbopack-ecmascript/src/async_chunk/chunk_item.rs
+4 −4 turbopack/crates/turbopack-ecmascript/src/lib.rs
+1 −1 turbopack/crates/turbopack-ecmascript/src/minify.rs
+2 −2 turbopack/crates/turbopack-ecmascript/src/parse.rs
+1 −1 turbopack/crates/turbopack-ecmascript/src/references/mod.rs
+1 −1 turbopack/crates/turbopack-ecmascript/src/references/node.rs
+2 −2 turbopack/crates/turbopack-ecmascript/src/references/raw.rs
+2 −2 turbopack/crates/turbopack-nodejs/src/chunking_context.rs
+1 −1 turbopack/crates/turbopack/src/global_module_ids.rs
+1 −1 turbopack/crates/turbopack/src/lib.rs
Loading