S25/teresa/matchmaking endpoints

[yut-code]

Notion ticket link

Matchmaking endpoints

Implementation description

• used pet and user service methods as much as possible without hindering performance.
• implemented matchmaking service + methods + routes

Steps to test

1. Change pet color levels and check <= or >= for findMatchingPets and findMatchingUsers
2. Check what happens when id in slug doesn't exist

one user can take care of pet no users can take care of pet pets user can take care of

no user found. similar message for pet

What should reviewers focus on?

• If getting all users is not efficient enough (interacting with ORM vs just using the service methods)
• Not much else I can think of

Checklist

• My PR name is descriptive and in imperative tense
• My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
• I have run the appropriate linter(s)
• I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

[sthuray]

We've kinda separated matchmaking services / functions unnecessarily

To make it a bit more intuitive, I'd suggest restructuring it like this:

Change endpoints:

• /matchmaking/users/:userId/pets ----> /users/match/:userId
• /matchmaking/pets/:petId/users ----> /pets/match/:petId
• get rid of /matchmaking router

Change services:

• matchmakingService.getMatchingUsersForPet(petId)
  ----> userService.getMatchingPetsForUser(userId)
• matchmakingService.getMatchingPetsForUser(userId) ----> petService.getMatchingUsersForPet(petId)
• get rid of matchmakingService

[sthuray]

Creating a middleware to handle the param validation will make this code a lot neater

See /middlewares/validators for examples of how other endpoints used it
-> create a matchPetsValidator function in petValidators

Do a similar process for /match/users/:petId

[Artyom-G]

The route is a bit awkward imo, same thing for the pets/match/pets.

Also think the methods should be documented more as to what they do, maybe a short descriptor at the function header. Other than that it works as it should