-
Notifications
You must be signed in to change notification settings - Fork 3
S25/teresa/matchmaking endpoints #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yut-code
wants to merge
25
commits into
main
Choose a base branch
from
S25/teresa/matchmaking-endpoints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 19 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
db5b88b
Update server.ts
yut-code ccd4073
endpoints
yut-code 4d37f6e
lint
yut-code 70831b7
Update matchmakingService.ts
yut-code ffa1530
Update matchmakingService.ts
yut-code f036965
Revert "Update matchmakingService.ts"
yut-code 9c80c17
Update matchmakingService.ts
yut-code c50d344
Update matchmakingService.ts
yut-code 8e3731c
Merge branch 'main' into S25/teresa/matchmaking-endpoints
yut-code c2cd362
removed matchmaking files
yut-code b4833e7
petservice userservice endpoints
yut-code 431cad7
Merge branch 'main' into S25/teresa/matchmaking-endpoints
yut-code 4354fbd
lint
yut-code fe44ec3
switch getMatchingUsersForPet into userService and vice versa
yut-code 94dbc66
remove discarded endpoints
yut-code a2a486d
lint
yut-code 5a8c9c1
more linting?
yut-code b0b20e1
linting
yut-code 8150f8e
lint
yut-code 1386688
fix comments
yut-code b2d7c07
add validators
yut-code f70bc78
fix dto type
yut-code b1e4887
linting
yut-code 6611fe0
more linting
yut-code 961ba42
indent
yut-code File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import { PetResponseDTO } from "./petService"; | ||
| import { UserDTO } from "../../types"; | ||
|
|
||
| export interface IMatchmakingService { | ||
| /* eslint-disable class-methods-use-this */ | ||
| getMatchingPetsForUser(userId: string): Promise<PetResponseDTO[]>; | ||
| getMatchingUsersForPet(petId: string): Promise<UserDTO[]>; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating a middleware to handle the param validation will make this code a lot neater
See /middlewares/validators for examples of how other endpoints used it
-> create a matchPetsValidator function in petValidators
Do a similar process for /match/users/:petId