Skip to content

Remove archived subjects from user management table and dropdown #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

Remove archived subjects from user management table and dropdown #124

merged 2 commits into from
Apr 16, 2025

Conversation

ColinToft
Copy link
Contributor

@ColinToft ColinToft commented Apr 13, 2025 •
edited
Loading

Notion Ticket

Ticket Name

Summary & Review Focus

Fixes nit:

  • There should not be archived email subs in the email subs dropdown.

I talked with Weinna and she said it should not show up in the list of tags either, so I also removed it there.

Testing Instructions

Checklist

  • PR title is descriptive and in imperative tense
  • Commit messages are descriptive, atomic, and follow best practices
  • Linter(s) have been run
  • Requested reviews from the PL and relevant team members

@ColinToft ColinToft self-assigned this Apr 13, 2025
@vercel Vercel
Copy link

vercel bot commented Apr 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 4:48pm

@ColinToft ColinToft requested a review from Copilot April 13, 2025 18:45
Copilot
Copilot AI reviewed Apr 13, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

ChinemeremChigbo
ChinemeremChigbo approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChinemeremChigbo ChinemeremChigbo merged commit 6b3cae6 into main Apr 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ChinemeremChigbo ChinemeremChigbo ChinemeremChigbo approved these changes

Assignees

@ColinToft ColinToft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ColinToft @ChinemeremChigbo