refactor: use column references instead of ID lookup#9189
Open
sissbruecker wants to merge 5 commits intomainfrom
Open
refactor: use column references instead of ID lookup#9189sissbruecker wants to merge 5 commits intomainfrom
sissbruecker wants to merge 5 commits intomainfrom
Conversation
sissbruecker
commented
Apr 24, 2026
| private GridElement grid; | ||
| private Long __generatedId; | ||
|
|
||
| public GridColumnElement(Long __generatedId, GridElement grid) { |
Contributor
Author
There was a problem hiding this comment.
Decided to drop the constructor. It's public, but I have a hard time seeing how someone might have directly used this.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GridColumnElementis currently not an actualTestBenchElement, but rather "virtual" element that allows referencing columns in the grid via IDs that are generated per column byGridElementwhenever columns are accessed. The JavaDoc mentions something about polyfilled browsers, but it seems this this is obsolete and using column references works fine now.This refactors
GridColumnElementto be aTestBenchElement, removes the old infrastructure around ID handling and simplifies several methods that work with columns. Includes the same change for Grid Pro TestBench helpers.