fix: Build should not depend on prepare#23925
Conversation
Running the build frontend task should not depend on the prepare task so that the tasks do not break each others caching. part of #17354
…covers those parts.
|
Works as expected with Gradle daemon, but it causes issues without. |
|
Seems we would need to come up with a new clean up strategy for the token file after a production build as this will not work as expected for the incremental build. |
|
Moved the token clean up to the respective plugins to handle. |
|
For Maven, I pushed #23945, that postpones the delete to the end of the build session. It works only if the plugin is configured as an extension, but it should help when using For Gradle, my concern is that using |
|
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinBuildFrontendTask.kt
Outdated
Show resolved
Hide resolved
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/FlowPlugin.kt
Outdated
Show resolved
Hide resolved
copy token file instead of recreation.
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/FlowPlugin.kt
Show resolved
Hide resolved
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/FlowPlugin.kt
Outdated
Show resolved
Hide resolved
Persist build-info hash from first hash onwards
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/FlowPlugin.kt
Show resolved
Hide resolved
this way running only buildFrontend clears token file.
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinBuildFrontendTask.kt
Show resolved
Hide resolved
|



Running the build frontend task
should not depend on the prepare
task so that the tasks do not
break each others caching.
part of #17354