Skip to content

fix: Build should not depend on prepare #23925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollovati merged 19 commits into from
Mar 23, 2026

Merge branch 'main' into issues/17354-build-frontend-without-prepare

9d3a212
Select commit
Loading
Failed to load commit list.
Merged

fix: Build should not depend on prepare #23925

Merge branch 'main' into issues/17354-build-frontend-without-prepare
9d3a212
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 23, 2026 in 1m 49s

Quality Gate passed

Issues
2572 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 1402 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_nd97DsEm91PDmpT&open=AZ0a_nd97DsEm91PDmpT&pullRequest=23925

Check warning on line 75 in flow-server/src/test/java/com/vaadin/flow/server/auth/DefaultInstantiatorMenuAccessControlTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Swap these 2 arguments so they are in the correct order: expected value, actual value. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_oyr7DsEm91PDm5C&open=AZ0a_oyr7DsEm91PDm5C&pullRequest=23925

Check warning on line 316 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/BeanModelTypeTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "PropertyFilter"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_nUB7DsEm91PDmn1&open=AZ0a_nUB7DsEm91PDmn1&pullRequest=23925

Check warning on line 51 in flow-server/src/test/java/com/vaadin/flow/server/communication/rpc/AttachTemplateChildRpcHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_oV77DsEm91PDmz0&open=AZ0a_oV77DsEm91PDmz0&pullRequest=23925

Check warning on line 806 in flow-server/src/test/java/com/vaadin/flow/shared/BrowserDetailsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "BrowserDetails"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_sDO7DsEm91PDnLK&open=AZ0a_sDO7DsEm91PDnLK&pullRequest=23925

Check warning on line 453 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/BeanModelTypeTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ClientUpdateMode"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_nUB7DsEm91PDmoY&open=AZ0a_nUB7DsEm91PDmoY&pullRequest=23925

Check warning on line 118 in flow-server/src/test/java/com/vaadin/flow/server/webcomponent/WebComponentModulesWriterTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_o8Y7DsEm91PDm5-&open=AZ0a_o8Y7DsEm91PDm5-&pullRequest=23925

Check failure on line 48 in flow-server/src/test/java/com/vaadin/flow/signals/shared/SharedListSignalNullabilityTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_pj_7DsEm91PDm8-&open=AZ0a_pj_7DsEm91PDm8-&pullRequest=23925

Check warning on line 233 in flow-server/src/test/java/com/vaadin/flow/component/WebComponentExporterTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "exporter" which hides the field declared at line 44. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_qGT7DsEm91PDm_J&open=AZ0a_qGT7DsEm91PDm_J&pullRequest=23925

Check warning on line 217 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ClientUpdateMode"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_nd97DsEm91PDmqh&open=AZ0a_nd97DsEm91PDmqh&pullRequest=23925

Check warning on line 475 in flow-server/src/test/java/com/vaadin/flow/server/SessionRouteRegistryTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Immediately return this expression instead of assigning it to the temporary variable "callable". 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_pC97DsEm91PDm6W&open=AZ0a_pC97DsEm91PDm6W&pullRequest=23925

Check warning on line 49 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelWithEncodersTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ClientUpdateMode"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_nJb7DsEm91PDmk0&open=AZ0a_nJb7DsEm91PDmk0&pullRequest=23925

Check warning on line 751 in flow-server/src/test/java/com/vaadin/flow/component/ComponentEventBusTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_qc37DsEm91PDnAC&open=AZ0a_qc37DsEm91PDnAC&pullRequest=23925

Check warning on line 343 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Exclude"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_nd97DsEm91PDmrU&open=AZ0a_nd97DsEm91PDmrU&pullRequest=23925

Check warning on line 2304 in flow-server/src/test/java/com/vaadin/flow/dom/ElementTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this String concatenation with Text block. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_rSn7DsEm91PDnFv&open=AZ0a_rSn7DsEm91PDnFv&pullRequest=23925

Check warning on line 575 in flow-server/src/test/java/com/vaadin/flow/server/VaadinSessionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "session" which hides the field declared at line 106. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_o9s7DsEm91PDm6H&open=AZ0a_o9s7DsEm91PDm6H&pullRequest=23925

Check warning on line 62 in flow-server/src/test/java/com/vaadin/flow/component/page/PageTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "firstParam" private field. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_p6b7DsEm91PDm-v&open=AZ0a_p6b7DsEm91PDm-v&pullRequest=23925

Check warning on line 215 in flow-server/src/test/java/com/vaadin/flow/internal/JacksonCodecTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_rq17DsEm91PDnG3&open=AZ0a_rq17DsEm91PDnG3&pullRequest=23925

Check warning on line 87 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelProxyHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "BeanModelType"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_nZg7DsEm91PDmo7&open=AZ0a_nZg7DsEm91PDmo7&pullRequest=23925

Check warning on line 233 in flow-server/src/test/java/com/vaadin/flow/internal/JacksonSerializerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this variable to not match a restricted identifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_rna7DsEm91PDnGq&open=AZ0a_rna7DsEm91PDnGq&pullRequest=23925

Check warning on line 272 in flow-server/src/test/java/com/vaadin/flow/server/communication/WebComponentProviderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "registry" which hides the field declared at line 89. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_oXk7DsEm91PDm0L&open=AZ0a_oXk7DsEm91PDm0L&pullRequest=23925

Check failure on line 230 in flow-server/src/test/java/com/vaadin/flow/server/communication/StreamReceiverHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_ocB7DsEm91PDm03&open=AZ0a_ocB7DsEm91PDm03&pullRequest=23925

Check warning on line 38 in flow-server/src/test/java/com/vaadin/flow/internal/ReflectToolsGetPrimitiveFieldValueTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this block of code, fill it in, or add a comment explaining why it is empty. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_rzg7DsEm91PDnHk&open=AZ0a_rzg7DsEm91PDnHk&pullRequest=23925

Check warning on line 755 in flow-server/src/test/java/com/vaadin/flow/server/communication/UploadHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the parentheses around the "event" parameter 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_od17DsEm91PDm2L&open=AZ0a_od17DsEm91PDm2L&pullRequest=23925

Check warning on line 334 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/BeanModelTypeTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "PropertyFilter"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0a_nUB7DsEm91PDmn6&open=AZ0a_nUB7DsEm91PDmn6&pullRequest=23925
View more details on SonarQubeCloud