Skip to content

test: remove unnecessary public modifiers from JUnit 6 tests (#23870) (CP: 25.1) #23928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcollovati wants to merge 1 commit into
base: 25.1
Choose a base branch
from
+3,524 −3,626

test: remove unnecessary public modifiers from JUnit 6 tests (#23870)

cdd6989
Select commit
Loading
Failed to load commit list.
Open

test: remove unnecessary public modifiers from JUnit 6 tests (#23870) (CP: 25.1) #23928

test: remove unnecessary public modifiers from JUnit 6 tests (#23870)
cdd6989
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 20, 2026 in 1m 21s

Quality Gate passed

Issues
135 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 246 in flow-server/src/test/java/com/vaadin/flow/server/startup/LookupServletContainerInitializerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'jakarta.servlet.ServletException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbDriwvE79ixsUbaG&open=AZ0AbDriwvE79ixsUbaG&pullRequest=23928

Check warning on line 176 in flow-server/src/test/java/com/vaadin/flow/server/communication/WebComponentBootstrapHandlerViteTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'com.vaadin.flow.server.ServiceException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbDcBwvE79ixsUbZw&open=AZ0AbDcBwvE79ixsUbZw&pullRequest=23928

Check warning on line 84 in flow-server/src/test/java/com/vaadin/flow/server/communication/JavaScriptBootstrapHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbDe4wvE79ixsUbZ0&open=AZ0AbDe4wvE79ixsUbZ0&pullRequest=23928

Check failure on line 147 in flow-server/src/test/java/com/vaadin/flow/server/startup/AnnotationValidatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbDtJwvE79ixsUbaH&open=AZ0AbDtJwvE79ixsUbaH&pullRequest=23928

Check warning on line 238 in flow-server/src/test/java/com/vaadin/flow/server/communication/rpc/ClientCallableBeanSupportTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbDHZwvE79ixsUbZi&open=AZ0AbDHZwvE79ixsUbZi&pullRequest=23928

Check warning on line 322 in flow-server/src/test/java/com/vaadin/flow/server/VaadinSessionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.InterruptedException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbECUwvE79ixsUbah&open=AZ0AbECUwvE79ixsUbah&pullRequest=23928

Check warning on line 107 in flow-server/src/test/java/com/vaadin/flow/server/communication/MetadataWriterTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbDg8wvE79ixsUbZ9&open=AZ0AbDg8wvE79ixsUbZ9&pullRequest=23928

Check failure on line 1008 in flow-server/src/test/java/com/vaadin/flow/server/startup/RouteRegistryInitializerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbDxvwvE79ixsUbaN&open=AZ0AbDxvwvE79ixsUbaN&pullRequest=23928

Check warning on line 67 in flow-server/src/test/java/com/vaadin/flow/router/RouterLinkTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.NoSuchFieldException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbF-rwvE79ixsUbba&open=AZ0AbF-rwvE79ixsUbba&pullRequest=23928

Check warning on line 69 in flow-server/src/test/java/com/vaadin/flow/internal/EncodeUtilTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbFzRwvE79ixsUbbM&open=AZ0AbFzRwvE79ixsUbbM&pullRequest=23928

Check warning on line 62 in flow-server/src/test/java/com/vaadin/flow/server/dau/DAUUtilsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbD7NwvE79ixsUbaZ&open=AZ0AbD7NwvE79ixsUbaZ&pullRequest=23928

Check warning on line 35 in flow-server/src/test/java/com/vaadin/flow/server/streams/DownloadEventTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbDDAwvE79ixsUbZe&open=AZ0AbDDAwvE79ixsUbZe&pullRequest=23928

Check failure on line 257 in flow-server/src/test/java/com/vaadin/flow/dom/ElementUtilTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbFF3wvE79ixsUba9&open=AZ0AbFF3wvE79ixsUba9&pullRequest=23928

Check failure on line 175 in flow-server/src/test/java/com/vaadin/flow/component/ComponentEventBusTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbE0RwvE79ixsUba1&open=AZ0AbE0RwvE79ixsUba1&pullRequest=23928

Check failure on line 732 in flow-server/src/test/java/com/vaadin/flow/server/communication/UploadHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbDW_wvE79ixsUbZq&open=AZ0AbDW_wvE79ixsUbZq&pullRequest=23928

Check failure on line 489 in flow-server/src/test/java/com/vaadin/flow/component/ComponentEventBusTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbE0RwvE79ixsUba2&open=AZ0AbE0RwvE79ixsUba2&pullRequest=23928

Check warning on line 116 in flow-server/src/test/java/com/vaadin/flow/server/VaadinSessionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbECUwvE79ixsUbaf&open=AZ0AbECUwvE79ixsUbaf&pullRequest=23928

Check warning on line 74 in flow-server/src/test/java/com/vaadin/flow/server/dau/DAUVaadinRequestInterceptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbD9SwvE79ixsUbac&open=AZ0AbD9SwvE79ixsUbac&pullRequest=23928

Check warning on line 111 in flow-server/src/test/java/com/vaadin/flow/router/RoutingTestBase.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.NoSuchFieldException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbGDlwvE79ixsUbbe&open=AZ0AbGDlwvE79ixsUbbe&pullRequest=23928

Check warning on line 59 in flow-server/src/test/java/com/vaadin/flow/server/AppShellRegistryStyleSheetDataFilePathTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbEQnwvE79ixsUban&open=AZ0AbEQnwvE79ixsUban&pullRequest=23928

Check warning on line 679 in flow-server/src/test/java/com/vaadin/flow/server/startup/RouteRegistryInitializerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'jakarta.servlet.ServletException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbDxvwvE79ixsUbaT&open=AZ0AbDxvwvE79ixsUbaT&pullRequest=23928

Check warning on line 53 in flow-server/src/test/java/com/vaadin/flow/router/RouterConfigurationUrlResolvingTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbGAdwvE79ixsUbbc&open=AZ0AbGAdwvE79ixsUbbc&pullRequest=23928

Check warning on line 120 in flow-server/src/test/java/com/vaadin/flow/internal/CurrentInstanceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbFxSwvE79ixsUbbJ&open=AZ0AbFxSwvE79ixsUbbJ&pullRequest=23928

Check failure on line 169 in flow-server/src/test/java/com/vaadin/flow/component/ComponentEventBusTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbE0RwvE79ixsUba0&open=AZ0AbE0RwvE79ixsUba0&pullRequest=23928

Check failure on line 270 in flow-server/src/test/java/com/vaadin/flow/server/communication/WebComponentBootstrapHandlerViteTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0AbDcBwvE79ixsUbZv&open=AZ0AbDcBwvE79ixsUbZv&pullRequest=23928
View more details on SonarQubeCloud