test: remove unnecessary public modifiers from JUnit 6 tests (#23870) (CP: 25.1)

flow-build-tools/src/test/java/com/vaadin/flow/server/frontend/AbstractUpdateImportsTest.java

@@ -877,7 +877,7 @@ private void assertImportOrder(String... imports) {
     }
 
     @Test
-    public void generatedFlowImports_importsAreOnTopBeforeOtherInstructions() {
+    void generatedFlowImports_importsAreOnTopBeforeOtherInstructions() {
         updater.run();
 
         List<String> lines = updater.getOutput()
@@ -886,7 +886,7 @@ public void generatedFlowImports_importsAreOnTopBeforeOtherInstructions() {
     }
 
     @Test
-    public void generatedFlowWebComponentImports_importsAreOnTopBeforeOtherInstructions()
+    void generatedFlowWebComponentImports_importsAreOnTopBeforeOtherInstructions()
             throws Exception {
         Class<?>[] testClasses = { CssImportExporter.class, FooCssImport.class,
                 UI.class, AllEagerAppConf.class };

flow-build-tools/src/test/java/com/vaadin/flow/server/frontend/TaskRunPnpmInstallTest.java

@@ -401,7 +401,7 @@ void runPnpmInstallAndCi_emptyDir_pnpmInstallAndCiIsExecuted()
     }
 
     @Test
-    public void runPnpmInstall_devMode_usesNoFrozenLockfile()
+    void runPnpmInstall_devMode_usesNoFrozenLockfile()
             throws ExecutionFailedException, IOException {
         TaskRunNpmInstall task = createTask();
         getNodeUpdater().modified = true;
@@ -417,7 +417,7 @@ public void runPnpmInstall_devMode_usesNoFrozenLockfile()
     }
 
     @Test
-    public void runPnpmInstall_ciBuild_usesFrozenLockfile()
+    void runPnpmInstall_ciBuild_usesFrozenLockfile()
             throws ExecutionFailedException, IOException {
         TaskRunNpmInstall ciTask = createCiTask();
         getNodeUpdater().modified = true;

flow-data/src/test/java/com/vaadin/flow/data/binder/BinderSignalTest.java

@@ -41,15 +41,15 @@
 /**
  * Tests for Binder and Binding integration with Signals.
  */
-public class BinderSignalTest extends SignalsUnitTest {
+class BinderSignalTest extends SignalsUnitTest {
 
     private TestTextField firstNameField;
     private TestTextField lastNameField;
     private Binder<Person> binder;
     private Person item;
 
     @BeforeEach
-    public void setup() {
+    void setup() {
         binder = new Binder<>(Person.class);
         item = new Person();
         firstNameField = new TestTextField();
@@ -69,7 +69,7 @@ private SerializablePredicate<String> hasTextValuesValidator(
 
     // verifies that Binding.valueSignal() works with property name bindings
     @Test
-    public void bindingValue_withBinderBindPropertyName() {
+    void bindingValue_withBinderBindPropertyName() {
         item.setFirstName("Alice");
 
         var field = new TestTextField();
@@ -86,7 +86,7 @@ public void bindingValue_withBinderBindPropertyName() {
 
     // verifies that Binding.valueSignal() works with getter/setter bindings
     @Test
-    public void bindingValue_withBinderBindGetterSetter() {
+    void bindingValue_withBinderBindGetterSetter() {
         binder = new Binder<>();
         item.setFirstName("Alice");
 
@@ -106,7 +106,7 @@ public void bindingValue_withBinderBindGetterSetter() {
     // verifies that Binding.valueSignal() with a signal-bound field works
     // correctly
     @Test
-    public void bindingValue_withSignal() {
+    void bindingValue_withSignal() {
         binder = new Binder<>();
         item.setFirstName("Alice");
 
@@ -131,15 +131,15 @@ public void bindingValue_withSignal() {
 
     // verifies that bindValue throws NPE for null signal
     @Test
-    public void bindValue_nullSignal_throwsNPE() {
+    void bindValue_nullSignal_throwsNPE() {
         var field = new TestTextField();
         assertThrows(NullPointerException.class,
                 () -> field.bindValue(null, null));
     }
 
     // verifies that cross-field validation works with signal-bound fields
     @Test
-    public void bindingValue_crossFieldValidation_withSignal() {
+    void bindingValue_crossFieldValidation_withSignal() {
         item.setFirstName("Alice");
         item.setLastName("Smith");
 
@@ -172,7 +172,7 @@ public void bindingValue_crossFieldValidation_withSignal() {
     // verifies that cross-field validation works also without signal-bound
     // fields
     @Test
-    public void bindingValue_crossFieldValidation_withoutSignal() {
+    void bindingValue_crossFieldValidation_withoutSignal() {
         item.setFirstName("Alice");
         item.setLastName("Smith");
 
@@ -199,7 +199,7 @@ public void bindingValue_crossFieldValidation_withoutSignal() {
     // verifies that cross-field validation works with mix of signal-bound and
     // not-bound fields
     @Test
-    public void bindingValue_crossFieldValidation_withMixedFields() {
+    void bindingValue_crossFieldValidation_withMixedFields() {
         item.setFirstName("Alice");
         item.setLastName("Smith");
         item.setAge(30);
@@ -271,7 +271,7 @@ public void bindingValue_crossFieldValidation_withMixedFields() {
 
     // verifies that cross-field validation works correctly with setBean
     @Test
-    public void crossFieldValidation_setBean_validationTriggeredOnFieldChange() {
+    void crossFieldValidation_setBean_validationTriggeredOnFieldChange() {
         item.setFirstName("Alice");
         item.setLastName("Smith");
 
@@ -308,7 +308,7 @@ public void crossFieldValidation_setBean_validationTriggeredOnFieldChange() {
 
     // verifies that cross-field validation works correctly with readBean
     @Test
-    public void crossFieldValidation_readBean_validationTriggeredOnFieldChange() {
+    void crossFieldValidation_readBean_validationTriggeredOnFieldChange() {
         item.setFirstName("Alice");
         item.setLastName("Smith");
 
@@ -346,7 +346,7 @@ public void crossFieldValidation_readBean_validationTriggeredOnFieldChange() {
     // verifies that cross-field validation works correctly with readBean and
     // signal-bound fields
     @Test
-    public void crossFieldValidation_readBean_withSignals() {
+    void crossFieldValidation_readBean_withSignals() {
         item.setFirstName("Alice");
         item.setLastName("Smith");
 
@@ -384,7 +384,7 @@ public void crossFieldValidation_readBean_withSignals() {
 
     // verifies that switching from setBean to readBean works correctly
     @Test
-    public void crossFieldValidation_switchFromSetBeanToReadBean() {
+    void crossFieldValidation_switchFromSetBeanToReadBean() {
         var item1 = new Person();
         item1.setFirstName("Alice");
         item1.setLastName("Smith");
@@ -427,7 +427,7 @@ public void crossFieldValidation_switchFromSetBeanToReadBean() {
 
     // verifies that cross-field validation works with records
     @Test
-    public void crossFieldValidation_record_readRecord() {
+    void crossFieldValidation_record_readRecord() {
         record TestRecord(String firstName, String lastName) {
         }
 
@@ -461,7 +461,7 @@ var record = new TestRecord("Alice", "Smith");
     // verifies that cross-field validation works with records and signal-bound
     // fields
     @Test
-    public void crossFieldValidation_record_readRecord_withSignals() {
+    void crossFieldValidation_record_readRecord_withSignals() {
         record TestRecord(String firstName, String lastName) {
         }
 
@@ -500,7 +500,7 @@ var record = new TestRecord("Alice", "Smith");
     // verifies that multiple bean changes work correctly with cross-field
     // validation
     @Test
-    public void crossFieldValidation_multipleBeanChanges() {
+    void crossFieldValidation_multipleBeanChanges() {
         var item1 = new Person();
         item1.setFirstName("Alice");
         item1.setLastName("Smith");
@@ -547,7 +547,7 @@ public void crossFieldValidation_multipleBeanChanges() {
     // verifies that cross-field validation state is preserved when changing
     // beans
     @Test
-    public void crossFieldValidation_validationStatePreservedOnBeanChange() {
+    void crossFieldValidation_validationStatePreservedOnBeanChange() {
         var item1 = new Person();
         item1.setFirstName("Alice");
         item1.setLastName("Smith");
@@ -585,7 +585,7 @@ public void crossFieldValidation_validationStatePreservedOnBeanChange() {
     // verifies that cross-field validation with signals only works when fields
     // are attached
     @Test
-    public void crossFieldValidation_onlyWorksWithAttachedFields() {
+    void crossFieldValidation_onlyWorksWithAttachedFields() {
         item.setFirstName("Alice");
         item.setLastName("Smith");
 
@@ -647,7 +647,7 @@ public void crossFieldValidation_onlyWorksWithAttachedFields() {
 
     // verifies that unbind() removes signal registration.
     @Test
-    public void unbind_removesSignalRegistration() {
+    void unbind_removesSignalRegistration() {
         item.setFirstName("Alice");
         item.setLastName("Smith");
 
@@ -690,7 +690,7 @@ public void unbind_removesSignalRegistration() {
     }
 
     @Test
-    public void beanLevelValidator_throwWhenSignalIsUsed() {
+    void beanLevelValidator_throwWhenSignalIsUsed() {
         item.setFirstName("Alice");
         var firstNameSignal = new ValueSignal<>("");
         UI.getCurrent().add(firstNameField);
@@ -714,7 +714,7 @@ public void beanLevelValidator_throwWhenSignalIsUsed() {
     }
 
     @Test
-    public void getValidationStatus_signalInitialized() {
+    void getValidationStatus_signalInitialized() {
         Signal<BinderValidationStatus<Person>> statusSignal = binder
                 .validationStatusSignal();
         assertNotNull(statusSignal,
@@ -724,7 +724,7 @@ public void getValidationStatus_signalInitialized() {
     }
 
     @Test
-    public void getValidationStatus_signalIsReadOnly() {
+    void getValidationStatus_signalIsReadOnly() {
         Signal<BinderValidationStatus<Person>> statusSignal = binder
                 .validationStatusSignal();
         assertThrows(ClassCastException.class,
@@ -733,7 +733,7 @@ public void getValidationStatus_signalIsReadOnly() {
     }
 
     @Test
-    public void getValidationStatus_statusChangeUpdatesSignal() {
+    void getValidationStatus_statusChangeUpdatesSignal() {
         item.setFirstName("Alice");
         item.setLastName("Smith");
         UI.getCurrent().add(firstNameField, lastNameField);
@@ -759,7 +759,7 @@ public void getValidationStatus_statusChangeUpdatesSignal() {
 
     // verifies that field-specific validation statuses are updated correctly
     @Test
-    public void getValidationStatus_fieldChanged_validationStatusSignalUpdated() {
+    void getValidationStatus_fieldChanged_validationStatusSignalUpdated() {
         item.setFirstName("Alice");
         item.setLastName("Smith");
         UI.getCurrent().add(firstNameField, lastNameField);
@@ -800,7 +800,7 @@ public void getValidationStatus_fieldChanged_validationStatusSignalUpdated() {
     }
 
     @Test
-    public void bindingValue_converterNotTracking() {
+    void bindingValue_converterNotTracking() {
         item.setLastName("Smith");
         item.setAge(30);
 
@@ -844,12 +844,12 @@ public Result<Integer> convertToModel(String value,
     }
 
     @Test
-    public void getValidationStatus_setBean_statusChangeRunEffects() {
+    void getValidationStatus_setBean_statusChangeRunEffects() {
         testStatusChangeRunEffects(() -> binder.setBean(item));
     }
 
     @Test
-    public void getValidationStatus_readBean_statusChangeRunEffects() {
+    void getValidationStatus_readBean_statusChangeRunEffects() {
         testStatusChangeRunEffects(() -> binder.readBean(item));
     }
 
@@ -893,17 +893,17 @@ private void testStatusChangeRunEffects(Runnable binderSetup) {
     }
 
     @Test
-    public void getValidationStatus_setBean_initialStatus() {
+    void getValidationStatus_setBean_initialStatus() {
         testInitialStatusChangeRunEffects(item -> binder.setBean(item));
     }
 
     @Test
-    public void getValidationStatus_readBean_initialStatus() {
+    void getValidationStatus_readBean_initialStatus() {
         testInitialStatusChangeRunEffects(item -> binder.readBean(item));
     }
 
     @Test
-    public void bindingValue_multipleValueSignalCalls_revalidateTriggeredForEach() {
+    void bindingValue_multipleValueSignalCalls_revalidateTriggeredForEach() {
         item.setFirstName("Alice");
         item.setLastName("Smith");
 
@@ -959,7 +959,7 @@ private void testInitialStatusChangeRunEffects(
     }
 
     @Test
-    public void asRequired_setBeanBeforeBind_fieldNotInvalidOnAttach() {
+    void asRequired_setBeanBeforeBind_fieldNotInvalidOnAttach() {
         var field = new TestTextField();
         binder.setBean(item);
         binder.forField(field).asRequired("Required field")

flow-html-components/src/test/java/com/vaadin/flow/component/html/AnchorBindTextTest.java

@@ -36,10 +36,10 @@
  * Unit tests for Anchor constructors that accept Signal<String> and related
  * bindText(Signal) semantics as documented in Anchor Javadoc.
  */
-public class AnchorBindTextTest extends SignalsUnitTest {
+class AnchorBindTextTest extends SignalsUnitTest {
 
     @Test
-    public void constructor_href_signal_lifecycleAndUpdates() {
+    void constructor_href_signal_lifecycleAndUpdates() {
         // Detached: binding inactive
         var signal = new ValueSignal<>("one");
         Anchor anchor = new Anchor("/path", signal);
@@ -69,15 +69,15 @@ public void constructor_href_signal_lifecycleAndUpdates() {
     }
 
     @Test
-    public void bindText_nullSignal_throwsNPE() {
+    void bindText_nullSignal_throwsNPE() {
         Anchor anchor = new Anchor("/a", "text");
         UI.getCurrent().add(anchor);
 
         assertThrows(NullPointerException.class, () -> anchor.bindText(null));
     }
 
     @Test
-    public void setText_whileBindingActive_throwsBindingActiveException() {
+    void setText_whileBindingActive_throwsBindingActiveException() {
         var signal = new ValueSignal<>("x");
         Anchor anchor = new Anchor("/x", signal);
         UI.getCurrent().add(anchor);
@@ -86,7 +86,7 @@ public void setText_whileBindingActive_throwsBindingActiveException() {
     }
 
     @Test
-    public void bindText_againWhileActive_throwsBindingActiveException() {
+    void bindText_againWhileActive_throwsBindingActiveException() {
         var signal = new ValueSignal<>("first");
         Anchor anchor = new Anchor("/x", signal);
         UI.getCurrent().add(anchor);
@@ -96,7 +96,7 @@ public void bindText_againWhileActive_throwsBindingActiveException() {
     }
 
     @Test
-    public void constructor_downloadHandler_signal_setsDownloadAttributeAccordingToHandlerType() {
+    void constructor_downloadHandler_signal_setsDownloadAttributeAccordingToHandlerType() {
         // AbstractDownloadHandler default: attachment (download attribute true)
         var attachmentHandler = new AttachmentHandler();
         Anchor a1 = new Anchor(attachmentHandler, new ValueSignal<>("d1"));

flow-html-components/src/test/java/com/vaadin/flow/component/html/FieldSetBindLegendTextTest.java

@@ -29,10 +29,10 @@
  * Tests for {@link FieldSet#bindLegendText(com.vaadin.flow.signals.Signal)}
  * using {@link SignalsUnitTest} setup.
  */
-public class FieldSetBindLegendTextTest extends SignalsUnitTest {
+class FieldSetBindLegendTextTest extends SignalsUnitTest {
 
     @Test
-    public void bindLegendText_updatesLegendOnSignalChange() {
+    void bindLegendText_updatesLegendOnSignalChange() {
         FieldSet fieldSet = new FieldSet();
         UI.getCurrent().add(fieldSet);
 
@@ -47,7 +47,7 @@ public void bindLegendText_updatesLegendOnSignalChange() {
     }
 
     @Test
-    public void bindLegendText_setLegendTextWhileBindingActive_throws() {
+    void bindLegendText_setLegendTextWhileBindingActive_throws() {
         FieldSet fieldSet = new FieldSet();
         UI.getCurrent().add(fieldSet);
 
@@ -59,7 +59,7 @@ public void bindLegendText_setLegendTextWhileBindingActive_throws() {
     }
 
     @Test
-    public void bindLegendText_nullSignal_throwsNPE() {
+    void bindLegendText_nullSignal_throwsNPE() {
         FieldSet fieldSet = new FieldSet();
         UI.getCurrent().add(fieldSet);
 
@@ -68,7 +68,7 @@ public void bindLegendText_nullSignal_throwsNPE() {
     }
 
     @Test
-    public void bindLegendText_attachedThenDetached_stopsUpdates() {
+    void bindLegendText_attachedThenDetached_stopsUpdates() {
         FieldSet fieldSet = new FieldSet();
         UI.getCurrent().add(fieldSet);