Merged
Conversation
Do not collect all generated icons into memory, but instead write each icon to disc flushing the cache to not use so much memory.
mcollovati
previously approved these changes
Mar 18, 2026
Collaborator
mcollovati
left a comment
mcollovati
left a comment
There was a problem hiding this comment.
Excellent improvement.
I wonder if we can make drawIconImage a static method in PwaIcon or some utility class to avoid code duplication.
Contributor
Author
|
Made the change so all draws are using the same method. |
|
mcollovati
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not collect all generated icons
into memory, but instead write
each icon to disc flushing the buffer
to not use so much memory.