Skip to content

chore: optimize pwa icon generation #23934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caalador merged 2 commits into from
Mar 20, 2026
+69 −52

Unify drawIconImage to one place

ea48ded
Select commit
Loading
Failed to load commit list.
Merged

chore: optimize pwa icon generation #23934

Unify drawIconImage to one place
ea48ded
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 19, 2026 in 1m 32s

Quality Gate passed

Issues
1477 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 530 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBNRXorkccECjS8H&open=AZ0FZBNRXorkccECjS8H&pullRequest=23934

Check failure on line 78 in flow-data/src/test/java/com/vaadin/flow/data/provider/AbstractLazyDataViewTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBmSXorkccECjTDo&open=AZ0FZBmSXorkccECjTDo&pullRequest=23934

Check warning on line 381 in flow-server/src/test/java/com/vaadin/flow/component/HasComponentsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZB7lXorkccECjTGF&open=AZ0FZB7lXorkccECjTGF&pullRequest=23934

Check warning on line 31 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/PropertyFilterTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "PropertyFilter"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBI4XorkccECjS2w&open=AZ0FZBI4XorkccECjS2w&pullRequest=23934

Check warning on line 339 in flow-polymer-template/src/test/java/com/vaadin/flow/component/polymertemplate/NpmTemplateParserTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "PolymerTemplate"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBTJXorkccECjS_c&open=AZ0FZBTJXorkccECjS_c&pullRequest=23934

Check warning on line 95 in flow-server/src/test/java/com/vaadin/flow/component/SignalPropertySupportTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZCHMXorkccECjTHW&open=AZ0FZCHMXorkccECjTHW&pullRequest=23934

Check warning on line 198 in flow-server/src/test/java/com/vaadin/flow/dom/ClassListGroupBindTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZCMGXorkccECjTIi&open=AZ0FZCMGXorkccECjTIi&pullRequest=23934

Check warning on line 132 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/KnownUnsupportedTypesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'action::run'. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBJcXorkccECjS3D&open=AZ0FZBJcXorkccECjS3D&pullRequest=23934

Check warning on line 367 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ClientUpdateMode"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBNRXorkccECjS7m&open=AZ0FZBNRXorkccECjS7m&pullRequest=23934

Check warning on line 165 in flow-polymer-template/src/test/java/com/vaadin/flow/component/polymertemplate/NpmTemplateParserTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "TemplateParser"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBTJXorkccECjS-6&open=AZ0FZBTJXorkccECjS-6&pullRequest=23934

Check warning on line 433 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelWithEncodersTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ClientUpdateMode"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBGoXorkccECjS13&open=AZ0FZBGoXorkccECjS13&pullRequest=23934

Check warning on line 133 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/ModelDescriptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ListModelType"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBQXXorkccECjS9N&open=AZ0FZBQXXorkccECjS9N&pullRequest=23934

Check warning on line 169 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelWithEncodersTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ClientUpdateMode"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBGoXorkccECjS1U&open=AZ0FZBGoXorkccECjS1U&pullRequest=23934

Check warning on line 136 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/ModelDescriptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "BeanModelType"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBQXXorkccECjS9P&open=AZ0FZBQXXorkccECjS9P&pullRequest=23934

Check warning on line 172 in flow-server/src/test/java/com/vaadin/flow/component/HtmlBindHtmlContentTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZCESXorkccECjTHC&open=AZ0FZCESXorkccECjTHC&pullRequest=23934

Check warning on line 94 in flow-server/src/test/java/com/vaadin/flow/component/HasValueBindReadOnlyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZB64XorkccECjTFg&open=AZ0FZB64XorkccECjTFg&pullRequest=23934

Check warning on line 906 in flow-data/src/test/java/com/vaadin/flow/data/binder/BinderSignalTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBd0XorkccECjTCw&open=AZ0FZBd0XorkccECjTCw&pullRequest=23934

Check warning on line 302 in flow-polymer-template/src/test/java/com/vaadin/flow/component/polymertemplate/PolymerTemplateTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "PolymerTemplate"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBWlXorkccECjTAi&open=AZ0FZBWlXorkccECjTAi&pullRequest=23934

Check warning on line 1383 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Include"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBNSXorkccECjS8y&open=AZ0FZBNSXorkccECjS8y&pullRequest=23934

Check warning on line 47 in flow-server/src/test/java/com/vaadin/flow/component/HtmlBindHtmlContentTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZCESXorkccECjTG5&open=AZ0FZCESXorkccECjTG5&pullRequest=23934

Check warning on line 110 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/ModelDescriptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ModelDescriptor"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBQXXorkccECjS9J&open=AZ0FZBQXXorkccECjS9J&pullRequest=23934

Check warning on line 35 in flow-server/src/test/java/com/vaadin/flow/component/HasValueBindReadOnlyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZB64XorkccECjTFc&open=AZ0FZB64XorkccECjTFc&pullRequest=23934

Check warning on line 433 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelWithEncodersTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "AllowClientUpdates"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBGoXorkccECjS12&open=AZ0FZBGoXorkccECjS12&pullRequest=23934

Check warning on line 314 in flow-server/src/test/java/com/vaadin/flow/component/AbstractFieldBindValueTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZB5VXorkccECjTFQ&open=AZ0FZB5VXorkccECjTFQ&pullRequest=23934

Check warning on line 130 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelWithEncodersTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "TemplateModel"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0FZBGoXorkccECjS1I&open=AZ0FZBGoXorkccECjS1I&pullRequest=23934
View more details on SonarQubeCloud