-
Notifications
You must be signed in to change notification settings - Fork 87
proto: implement rich text editor impovements #10409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
proto: implement rich text editor impovements #10409
Conversation
| display: flex; | ||
| flex-direction: column; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think I might leave out this wrapper element, and set the layout on the host.
|
One persisting thought I have about our field components is that instead of all of them individually reimplementing shared features (granted, via mixins), we would have a general-purpose "field" wrapper component, and then dedicated "editors" or "inputs" for various types (date, email, number, text, rich text, etc). I’ve explored that idea some years ago: https://jelements.netlify.app/prototypes/field/ Therefore, what I’d rather see, is that we don't add more features to Rich Text Editor, but consider implementing that general-purpose "field" component instead. And then maybe a "Rich Text Field" component for convenience. But that’s a bigger decision that needs broader discussion and agreement across the products (affects Flow as well). |
ab081ce to
780989c
Compare
…n' of https://github.com/vaadin/web-components into proto-implement-rich-text-editor-label-helper-validation
|



Description
This PR is a prototype for implementing the following for the RichTextEditor:
Some notes:
Prototype for the improvements in https://github.com/vaadin/components-team-tasks/issues/631
Type of change
Checklist