fix(ci): install deps once then cache

[neriumpete]

Overview
This PR refactors the CI workflow to address the issue of redundant dependency installation and p2pd builds across multiple matrix jobs. By moving these steps into a dedicated job, we now install and cache dependencies only once per CI run, reducing overall build time and resource consumption.

Changes
Separated Dependency Setup:

• Created a new job (setup-dependencies) that runs before the matrix-based test job.
• Moved dependency installation steps—including setting up Nim, Go, Python, installing Nimble dependencies, and building the p2pd daemon—into this job.

Caching Improvements:
Nimble Dependencies: Caches the nimbledeps directory using a key based on Nim version, builder, CPU type, and a hash of the .pinned file.
p2pd Build Artifact: Implements caching for the p2pd build, so it’s only built if the cache isn’t found.

Enhanced Environment Consistency:
Both the setup and test jobs now consistently configure the environment (using the same custom actions for Nim, and the appropriate setup for Go and Python).
Improved directory creation by using mkdir -p to ensure robustness.

Concurrency Management:
The concurrency settings ensure that the setup job runs only once per branch or pull request, avoiding simultaneous redundant executions.

Impact

• Reduced Redundancy: By isolating dependency setup and caching the results, each matrix test job restores pre-installed dependencies rather than re-installing them.
• Faster CI Builds: This separation leads to more efficient use of resources and decreased overall build times.
  Improved Consistency: Ensures that all jobs run with the same pre-installed environment, reducing potential configuration discrepancies.
• This change directly addresses the issue of multiple redundant dependency installations and p2pd builds by moving them to a dedicated, cached setup job.

Closes #1154

[vladopajic]

thanks for showing initiative.

instead of caching dependencies, it might be even better to optimize them by avoiding them.

• building p2pd: could be downloaded as binary and added to path. this would avoid:
  • setup of go
  • downloading sources and building go-libp2p-daemon
• can pyton be avoided?
• could all platforms reuse nim dependencies? they are just source files? could we download them once and just reuse them in test jobs
• could there be only one setup-dependencies job (platform impended) that is reused by test jobs? if so this way to go, if not then there is not need of splitting setup-dependencies and test because it will just introduce unnecessary blocking.

[neriumpete]

Note - I removed the i386 platform from the matrix because no official 32-bit p2pd binary is available, causing build failures. So it needs to be removed if we don't want to install go

[vladopajic]

@neriumpete sir, thanks for effort!

ci i currently failing, it looks like deamon is not in path or something? may i suggest to run changes in ci of your fork and push back here once it passes over there?

[vladopajic]

LGTM - if ci is passing.

@neriumpete it would be also nice to update PR title and description to match what has been done in PR since it was changed since initial commit.

@richard-ramos it will require approval from you, and also removing i386 from ci test requirements since it was removed.

[richard-ramos]

I think it should be fine to drop Linux i386 since this architecture should be rare (looking for examples across internet it seems to be used on older machines). Let's cc: @arnetheduck for his blessings / insight.

--
Having said that, I see that other targets are failing with:

    Unhandled error: No such file or directory
Additional info: Could not find command: '/home/runner/work/nim-libp2p/nim-libp2p/.ci-bin/p2pd'. OS error: Exec format error [OSError]

Also, the commits must be signed.

[richard-ramos]

Yeah after giving it some thought, let's drop i386 support.

[richard-ramos]

LGTM!
Good work

[richard-ramos]

this echo is likely unneeded.

[richard-ramos]

This is no longer needed. I ended up removing python from mbedtls (and ended up remobing mbedtls too :) )

[richard-ramos]

This can be removed

Suggested change

	- name: Setup python
	run: |
	mkdir -p .venv
	python -m venv .venv

[vladopajic]

@richard-ramos not what suggestion implies? did you forget to make empty suggestion?

[richard-ramos]

yeah... forgot to actually remove the code from my suggestion. fixed

[vladopajic]

there is # Verify it's working step above? is it really necessary to verify two times?

[vladopajic]

this action didn't work?