fix(service-discovery): drain bootstrap futures on shutdown

[Copilot]

Summary

auto-advertise on start could leave a service-discovery RPC stream alive after teardown because bootstrap futures were only signaled for cancellation, not drained. This change makes shutdown wait for those bootstrap cancellations to complete so the associated streams close before tracker checks run.

• Root cause

  • ServiceDiscovery.stop() cleared serviceBootstrapFuts after cancelSoon()
  • bootstrap refresh RPCs could still be unwinding while the test moved on
  • one LPChannel could remain open long enough to poison later tests

• Change

  • convert bootstrap shutdown from fire-and-forget cancellation to drained cancellation
  • preserve the existing raises: [] shutdown contract by waiting through noCancel
  • converted other future cancellations to cancelAndWait to have same pattern in this proc

Affected Areas

• Gossipsub

• Transports

• Peer Management / Discovery

• Protocol Logic

• Build / Tooling

• Other

Compatibility & Downstream Validation

Reference PRs / branches / commits demonstrating successful integration:

• Nimbus:
  N/A

• Waku:
  N/A

• Codex:
  N/A

Impact on Library Users

No API change. Internal shutdown behavior is stricter: service-discovery now waits for bootstrap work to finish cancelling before completing stop, which removes a teardown race without changing steady-state protocol behavior.

Risk Assessment

Low risk.

• shutdown-only change in service-discovery
• no wire format or protocol semantics change
• possible minor increase in stop latency when bootstrap futures are active
• reduces leaked-resource risk during teardown

References

• Issue: bug: auto-advertise on start
• vacp2p/nim-libp2p#2822

Additional Notes

This is intentionally narrow in scope: only bootstrap future teardown changed. Other service-discovery background loops keep their existing shutdown behavior.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.06%. Comparing base (3a59e0e) to head (2cca903).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2823      +/-   ##
==========================================
- Coverage   81.07%   81.06%   -0.02%     
==========================================
  Files         171      171              
  Lines       31135    31134       -1     
  Branches       12       13       +1     
==========================================
- Hits        25244    25239       -5     
- Misses       5891     5895       +4     

Files with missing lines	Coverage Δ
libp2p/protocols/service_discovery.nim	87.79% <100.00%> (-0.08%)	⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[richard-ramos]

interesting trick

[gmelodie]

nit?

Suggested change

	if not disco.advertiserMaintenanceLoop.isNil:
	if not disco.advertiserMaintenanceLoop.isNil():

[vladopajic]

adjective-like getters should not use ()