wip: refactor everything #268
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/268 |
Member
|
This looks amazing @mustaphaturhan! I just had a quick look and the new UI looks a lot cleaner already. I'm not going through the entire code, but I see that you broke up that huge map component, which was long overdue. As I said before, I like the idea of using shdcn which just pulls the components into the repo, this may help us maintain the UI longer into the future. Happy to merge this once you've gone through the remaining TODO's :-) |
- Removed `@emotion/react` and `@emotion/styled` from dependencies. - Updated versions for several packages including `axios`, `date-fns`, `lucide-react`, `maplibre-gl`, `tailwind-merge`, and `tailwindcss`. - Deleted unused components: `Checkbox` and `CustomSlider`. - Introduced new UI components: `CheckboxSetting`, `SelectSetting`, and updated `SliderSetting` for better functionality. - Refactored `SettingsPanel` to utilize new UI components and improve settings management.
- Changed the application name from `converter-demo-app` to `valhalla-web` and updated the version to `1.0.0` in `package.json`. - Refactored settings-related imports and variables in `common-actions.ts`, `settings-panel.tsx`, and `settings-options.ts` for consistency and clarity. - Introduced new types and structured settings data for better organization and maintainability.
- refactored the structure of components by moving them into a more organized directory structure under `src/components`.
…t versions to fix vulnerable gh-pages package
mustaphaturhan
force-pushed
the
feature/refactor-everything
branch
from
33a6e3d to
3e41379
Compare
… `useLayoutEffect`, and update eslint configuration.
… remove unused `pairwise` utility
Collaborator
Author
|
I think I am coming to end but can you test the app again? @chrstnbwnkl @nilsnolde |
…g to info popup, and refine popup css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with #256.
🛠️ Fixes Issue
react-beautiful-dndto@hello-pangea/dndsincereact-beautiful-dndis not supporting anymore. In the future, we will migrate to better dnd library but@hello-pangea/dndis full compatible withreact-beautiful-dndrenderwithcreateRootsince it is deprecated.semantic-ui-reactand starts to usetailwindcsssemantic-ui-reactis very outdated library and we have better alternatives at the moment. Instead of it, we are starting to use our design system library that created with shadcn. So we will be able to freely change everything.emotionnow.mapStateToPropsin favor of react hooks. UseuseSelectoranduseDispatchinstead of it. However, it is not finalized yet. We may completely deprecate it in future updates.wpsexist in the URL.valhalla-weband makes version 1.0.0componentsfolder for better, organized structure.envfile.This pull request is still work in progress but I wanted to create it to get some opinions from people. So if you have some recommendations or objections, please let me know 🙏🏻.
Todos
tanstack/queryfor request for better caching support. For example, reverse geocode responses aren't changing a lot. So we can cache the values.Follow-ups
📄 Note to reviewers
Good luck. Sorry for this huge pull request :(
📷 Screenshots