Open
Conversation
mkmkme
requested changes
Mar 28, 2026
Collaborator
mkmkme
left a comment
mkmkme
left a comment
There was a problem hiding this comment.
Thanks, the change looks good to me. I've left two suggestions regarding the URLs in the comments. It was the issue with the original comment too, but since we're changing this let's make it proper.
The Read the Docs project `valkey-py-cluster` doesn't exist. This was likely caused by a `redis->valkey` search and replace. Signed-off-by: Kurt McKee <contactme@kurtmckee.org>
Signed-off-by: Kurt McKee <contactme@kurtmckee.org> Co-authored-by: Mikhail Koviazin <github@mkmk.aleeas.com> Signed-off-by: Kurt McKee <contactme@kurtmckee.org>
mkmkme
force-pushed
the
fix-pubsub-links
branch
from
f50a776 to
d785a1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The Read the Docs project
valkey-py-clusterdoesn't exist. This was likely caused by aredis->valkeysearch and replace.Pull Request check-list