Skip to content

Fix ClusterPubSub limitation links #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kurtmckee wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −5
Open

Fix ClusterPubSub limitation links #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d478675
Fix ClusterPubSub limitation links
kurtmckee Mar 25, 2026
d785a1d
Apply suggestions from code review
kurtmckee Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/test_asyncio/test_pubsub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,8 +434,7 @@ async def test_unicode_channel_message_handler(self, r: valkey.Valkey):
await p.aclose()

@pytest.mark.onlynoncluster
# see: https://valkey-py-cluster.readthedocs.io/en/stable/pubsub.html
# #known-limitations-with-pubsub
# see: https://valkey-py.readthedocs.io/en/latest/clustering.html#known-pubsub-limitations # noqa: E501
async def test_unicode_pattern_message_handler(self, r: valkey.Valkey):
p = r.pubsub(ignore_subscribe_messages=True)
pattern = "uni" + chr(4456) + "*"
Expand Down
3 changes: 1 addition & 2 deletions tests/test_pubsub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,8 +569,7 @@ def test_unicode_shard_channel_message_handler(self, r):
assert self.message == make_message("smessage", channel, "test message")

@pytest.mark.onlynoncluster
# see: https://valkey-py-cluster.readthedocs.io/en/stable/pubsub.html
# #known-limitations-with-pubsub
# see: https://valkey-py.readthedocs.io/en/latest/clustering.html#known-pubsub-limitations # noqa: E501
def test_unicode_pattern_message_handler(self, r):
p = r.pubsub(ignore_subscribe_messages=True)
pattern = "uni" + chr(4456) + "*"
Expand Down
2 changes: 1 addition & 1 deletion valkey/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1700,7 +1700,7 @@ class ClusterPubSub(PubSub):
IMPORTANT: before using ClusterPubSub, read about the known limitations
with pubsub in Cluster mode and learn how to workaround them:
https://valkey-py-cluster.readthedocs.io/en/stable/pubsub.html
https://valkey-py.readthedocs.io/en/latest/clustering.html#known-pubsub-limitations
"""

def __init__(
Expand Down