Remove continue-on-error so the default applies

[Adamantios]

Proposed changes

The default value for the continue-on-error flag is false. Because the flag was set to true for the unit tests, a green status was being reported despite them failing due to an infinite loop introduced in the dev mode in #2221. As a result, the failure went unnoticed for 5 months, which eventually led to additional bugs in the CLI, since its tests appeared to pass.

This issue was first mentioned in #2292 (comment).

Fixes

n/a

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

• Non-breaking fix (non-breaking change which fixes an issue)
• Breaking fix (breaking change which fixes an issue)
• Non-breaking feature (non-breaking change which adds functionality)
• Breaking feature (breaking change which adds functionality)
• Refactor (non-breaking change which changes implementation)
• Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

• I have read the CONTRIBUTING doc
• I am making a pull request against the main branch (left side). Also you should start your branch off our main.
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have locally run services that could be impacted and they do not present failures derived from my changes
• Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
• Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

n/a

[OjusWiZard]

[solarw]

lgtm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.12%. Comparing base (8bdce08) to head (d3a9de0).
Report is 235 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2303      +/-   ##
==========================================
- Coverage   94.40%   93.12%   -1.28%     
==========================================
  Files         260      225      -35     
  Lines       16110    16366     +256     
==========================================
+ Hits        15208    15241      +33     
- Misses        902     1125     +223     

Flag	Coverage Δ
unittests	93.12% <100.00%> (-1.28%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.