Skip to content

feat(xo6): add detach host button - #10179

Merged
J0ris-K merged 8 commits into
masterfrom
xo6/add-detach-host-button
Aug 31, 2026
Merged

feat(xo6): add detach host button#10179
J0ris-K merged 8 commits into
masterfrom
xo6/add-detach-host-button

Conversation

@MarieGarde

@MarieGarde MarieGarde commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Description

!!! Merge after #10178 !!!

⚠️ WARNING ⚠️
!! Do not run tests on the classic test environment !!
Come see me when you want to test

  • Add the possibility to detach Host (Host must be running)

  • Detaching a host removes it from the pool but don't destroy it

  • For the detach, we don’t have a loader a host. A detach is checked on the pool, where we check the "eject". Except that we can’t know which host is being detached with the current eject, so all the hosts in a pool would have a loader whereas only one of them would be detaching itself. Maybe ask the back to create a new HOST_ALLOWED_OPERATIONS for detach?

  • The xo-host-util file will be refactored soon, following the merge of a backend PR that harmonizes host pending operations. This whole part will be reworked at that point.

Light Dark
Treeview buttond Capture d’écran du 2026-08-28 15-32-52 Capture d’écran du 2026-08-28 15-32-55
Header button Capture d’écran du 2026-08-28 15-33-49 Capture d’écran du 2026-08-28 15-33-42
Detach host Capture d’écran du 2026-07-28 11-20-38 Capture d’écran du 2026-07-28 11-20-34

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.
  4. If the PR relates to a change in the openAPI specification, a member of the DevOps team must also participate in the review.

@MarieGarde MarieGarde changed the title first commit feat(xo6): add detach host button Jul 28, 2026
@MarieGarde MarieGarde self-assigned this Jul 28, 2026
@MarieGarde
MarieGarde marked this pull request as ready for review July 28, 2026 11:19
@MarieGarde
MarieGarde force-pushed the xo6/add-detach-host-button branch from 144a9d8 to feb3d0f Compare August 3, 2026 07:19
@Elise-FZI
Elise-FZI requested review from Elise-FZI and removed request for OlivierFL August 12, 2026 13:54
Comment thread @xen-orchestra/web/src/modules/host/jobs/xo-host-detach.job.ts Outdated
@sylvere-a

Copy link
Copy Markdown
Collaborator

Since this is the last PR of the stack, it would be a good place to use linked translations for the duplicated locale values:

  • "Host is not running"
  • "Host is missing"

(same in FR)

Base automatically changed from xo6/add-restart-toolstack-host-button to master August 28, 2026 08:37
@MarieGarde
MarieGarde force-pushed the xo6/add-detach-host-button branch from f7d66ff to 03eba5e Compare August 28, 2026 09:17
@Elise-FZI
Elise-FZI self-requested a review August 28, 2026 11:53
@MarieGarde
MarieGarde force-pushed the xo6/add-detach-host-button branch from 1bba3ef to ee1ecc9 Compare August 28, 2026 14:33
@J0ris-K
J0ris-K merged commit 62013d4 into master Aug 31, 2026
1 of 2 checks passed
@J0ris-K
J0ris-K deleted the xo6/add-detach-host-button branch August 31, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants