feat(xo6): add detach host button - #10179
Merged
Merged
Conversation
MarieGarde
marked this pull request as ready for review
July 28, 2026 11:19
MarieGarde
force-pushed
the
xo6/add-detach-host-button
branch
from
August 3, 2026 07:19
144a9d8 to
feb3d0f
Compare
amouillard-vates
approved these changes
Aug 3, 2026
Elise-FZI
requested changes
Aug 12, 2026
Collaborator
|
Since this is the last PR of the stack, it would be a good place to use linked translations for the duplicated locale values:
(same in FR) |
Base automatically changed from
xo6/add-restart-toolstack-host-button
to
master
August 28, 2026 08:37
MarieGarde
force-pushed
the
xo6/add-detach-host-button
branch
from
August 28, 2026 09:17
f7d66ff to
03eba5e
Compare
Elise-FZI
self-requested a review
August 28, 2026 11:53
Elise-FZI
approved these changes
Aug 28, 2026
MarieGarde
force-pushed
the
xo6/add-detach-host-button
branch
from
August 28, 2026 14:33
1bba3ef to
ee1ecc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
!!! Merge after #10178 !!!
!! Do not run tests on the classic test environment !!
Come see me when you want to test
Add the possibility to detach Host (Host must be running)
Detaching a host removes it from the pool but don't destroy it
For the detach, we don’t have a loader a host. A detach is checked on the pool, where we check the "eject". Except that we can’t know which host is being detached with the current eject, so all the hosts in a pool would have a loader whereas only one of them would be detaching itself. Maybe ask the back to create a new HOST_ALLOWED_OPERATIONS for detach?
The xo-host-util file will be refactored soon, following the merge of a backend PR that harmonizes host pending operations. This whole part will be reworked at that point.
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.
Notes: