fix(xo-server): change current_operations display for xo host and poo… - #10283
Open
ayoub-el-kajji-v wants to merge 6 commits into
Open
fix(xo-server): change current_operations display for xo host and poo…#10283ayoub-el-kajji-v wants to merge 6 commits into
ayoub-el-kajji-v wants to merge 6 commits into
Conversation
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
ayoub-el-kajji-v
marked this pull request as ready for review
August 20, 2026 08:50
spacotte-vates
approved these changes
Aug 20, 2026
spacotte-vates
left a comment
spacotte-vates
left a comment
Collaborator
There was a problem hiding this comment.
Details, otherwise LGTM
| - [Warm migration] Fix `Vm target of warm migration not found` error at the end of a migration (PR [#10210](https://github.com/vatesfr/xen-orchestra/pull/10210)) | ||
| - **XO 5**: | ||
| - [VM/Console] Fix the page header and tab navigation disappearing permanently in the console tab (PR [#10007](https://github.com/vatesfr/xen-orchestra/pull/10007)) | ||
| - [XO server] Fix current_operations format on host and pool objects (PR [#10283](https://github.com/vatesfr/xen-orchestra/pull/10283)) |
Collaborator
There was a problem hiding this comment.
I think it's better to move it above the XO 5/XO 6 section otherwise it's a bit confusing where it belongs.
| auto_poweron: obj.other_config.auto_poweron === 'true', | ||
| crashDumpSr: link(obj, 'crash_dump_SR'), | ||
| current_operations: obj.current_operations, | ||
| current_operations: currentOperations, |
Collaborator
There was a problem hiding this comment.
Suggested change
| current_operations: currentOperations, | |
| current_operations: getCurrentOperations(obj), |
Prevents using a const, not very important.
MathieuRA
requested changes
Aug 26, 2026
MathieuRA
left a comment
MathieuRA
left a comment
Member
There was a problem hiding this comment.
The code LGTM, but during my tests, it didn't work as expected.
For example, if you shut down a host, the shutdown operation does not appear in the object's current_operations
Comment on lines
+74
to
+79
| // Builds a { taskId -> operation } map from a XAPI object's raw | ||
| // current_operations ({ OpaqueRef -> operation }), dropping any entry | ||
| // whose task is no longer present in the local cache (e.g. it finished | ||
| // and was collected). This lets consumers know an operation is truly | ||
| // over once it disappears from the map, instead of seeing a stale entry | ||
| // forever. |
Member
There was a problem hiding this comment.
Convert this comment into JSDoc so that it appears when hovering over the function signature
| - [Backup/File restore, Backup/Health] An unreachable backup repository no longer slows down every listing: it is skipped after a delay and retried with an increasing backoff (PR [#10205](https://github.com/vatesfr/xen-orchestra/pull/10205)) | ||
| - [REST API] Fix `/users/:id/authentication_tokens` sometimes did not return the token used to make the request (PR [#10233](https://github.com/vatesfr/xen-orchestra/pull/10233)) | ||
| - [XO server] Fix a random behavior regarding `coresPerSocket` update (PR [#10201](https://github.com/vatesfr/xen-orchestra/pull/10201)) | ||
| - [XO server] Fix current_operations format on host and pool objects (PR [#10283](https://github.com/vatesfr/xen-orchestra/pull/10283)) |
Member
There was a problem hiding this comment.
update xo-server to minor instead patch
| - [Backup/File restore, Backup/Health] An unreachable backup repository no longer slows down every listing: it is skipped after a delay and retried with an increasing backoff (PR [#10205](https://github.com/vatesfr/xen-orchestra/pull/10205)) | ||
| - [REST API] Fix `/users/:id/authentication_tokens` sometimes did not return the token used to make the request (PR [#10233](https://github.com/vatesfr/xen-orchestra/pull/10233)) | ||
| - [XO server] Fix a random behavior regarding `coresPerSocket` update (PR [#10201](https://github.com/vatesfr/xen-orchestra/pull/10201)) | ||
| - [XO server] Fix current_operations format on host and pool objects (PR [#10283](https://github.com/vatesfr/xen-orchestra/pull/10283)) |
Member
There was a problem hiding this comment.
Each new entry must be placed at the end of the section (to facilitate conflict resolution).
They are reorganized during the technical release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[XO-2810]
This PR is a fix to change the display format of the current_operations object in Host and Pool to be displayed with the same format of the current_operations in VM
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.
Notes: