Skip to content

Default phase filter settings in Makerbase 75_100 configs#902

Open
jwidess wants to merge 1 commit into
vedderb:masterfrom
jwidess:master
Open

Default phase filter settings in Makerbase 75_100 configs#902
jwidess wants to merge 1 commit into
vedderb:masterfrom
jwidess:master

Conversation

@jwidess
Copy link
Copy Markdown

@jwidess jwidess commented Apr 26, 2026

This commit adds an #ifdef macro to the Makerbase hw_mksesc_75_100_core.h and hw_mksesc_75_100_v2_core.h hardware config headers to default phase filters to the appropriate setting (usually off) based on HW config.

I added this as restoring defaults currently inherits the global fallback of true from mcconf_default.h. However, for config variants without phase filters, this seems to only affect the stored/default config value and not the actual behaviour.

I've compiled and flashed this to my own MKSESC 75100 from AliExpress, and it works fine, correctly defaulting phase filters to off on defaults.

This commit adds an #ifdef macro to the Makerbase 75_100 and 75_100_V2 hardware config headers to default phase filters to the appropriate setting (usually off) based on HW config.
@vedderb
Copy link
Copy Markdown
Owner

vedderb commented Apr 27, 2026

Have you confirmed that this actually makes any difference? If the hardware has no filters the setting should not do anything.

@jwidess
Copy link
Copy Markdown
Author

jwidess commented Apr 27, 2026

Have you confirmed that this actually makes any difference? If the hardware has no filters the setting should not do anything.

Apologies, I should have clarified that yes, you are correct, this functionally does not change anything, as if the HW config does not enable phase filters, this setting is inert. It is only meant to default the "Enable Phase Filters" setting to false on Makerbase ESCs when they are not enabled to provide a bit of peace of mind and reduce confusion for new users.

EDIT: This confusion is mainly aided by the notes on sellers' pages saying things like,

Phase filering is not available for MKSESC75100 !
Please turn off the phase filter function and choose "false" in vesc_tool when use firmware version on or above 5.3 (VESC_TOOL 3.01). Without turning off the phase filter will result in esc damage. Please do not restore the default parameters when using the wizard interface.

However as the firmwares properly disable phase filters this isn't true, but may confuse newbies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants