Default phase filter settings in Makerbase 75_100 configs#902
Conversation
This commit adds an #ifdef macro to the Makerbase 75_100 and 75_100_V2 hardware config headers to default phase filters to the appropriate setting (usually off) based on HW config.
|
Have you confirmed that this actually makes any difference? If the hardware has no filters the setting should not do anything. |
Apologies, I should have clarified that yes, you are correct, this functionally does not change anything, as if the HW config does not enable phase filters, this setting is inert. It is only meant to default the "Enable Phase Filters" setting to false on Makerbase ESCs when they are not enabled to provide a bit of peace of mind and reduce confusion for new users. EDIT: This confusion is mainly aided by the notes on sellers' pages saying things like,
However as the firmwares properly disable phase filters this isn't true, but may confuse newbies. |
This commit adds an #ifdef macro to the Makerbase
hw_mksesc_75_100_core.handhw_mksesc_75_100_v2_core.hhardware config headers to default phase filters to the appropriate setting (usually off) based on HW config.I added this as restoring defaults currently inherits the global fallback of true from
mcconf_default.h. However, for config variants without phase filters, this seems to only affect the stored/default config value and not the actual behaviour.I've compiled and flashed this to my own MKSESC 75100 from AliExpress, and it works fine, correctly defaulting phase filters to off on defaults.