Fix volume snapshotter usage of AAD URI#256
Fix volume snapshotter usage of AAD URI#256dylanbossie-rise8 wants to merge 2 commits intovelero-io:mainfrom
Conversation
volume snapshotting currently does not work with Azure workload identities due to ValidateVolumeSnapshotterConfig throwing an error, since the AAD URI is not recognized in that method as a valid key. this will resolve the issue. Signed-off-by: Dylan Bossie <dylanbossie@gmail.com>
Signed-off-by: Dylan Bossie <dylanbossie@gmail.com>
dylanbossie-rise8
force-pushed
the
main
branch
from
86fda17 to
1dffdf7
Compare
|
@shubham-pampattiwar @ywk253100 Can you please review this if you have time, this is something that was overlooked in one of my previous commits :) |
|
I don't see it being referenced in code other than docs. can you clarify where the value of this config is used? |
Jeremy-Boyle
left a comment
Jeremy-Boyle
left a comment
There was a problem hiding this comment.
Please make these changes
| @@ -0,0 +1 @@ | |||
| Update volume_snapshotter to correctly use AAD URI which fixes behavior for Azure Workload Identities No newline at end of file | |||
There was a problem hiding this comment.
Please remove this file @dylanbossie-rise8 , its automatically generated via commits, when a release is cut.
There was a problem hiding this comment.
changelogs/unreleased/ is not automatically generated at least for all other velero repos.
I suggests keeping the changelog here.
There was a problem hiding this comment.
changelogs/unreleased/ is not automatically generated at least for all other velero repos.
I suggests keeping the changelog here.
Ah thanks ! I didn't notice that i just looked at some other commits and MRs good job @dylanbossie-rise8 for noticing that. Side, note did you have any further questions for above ?
|
/cc @anshulahuja98 |
|
@shubham-pampattiwar / @kaovilai I don't seem to have access to trigger the CI |
|
Not me. |
|
yeah me too. same access as @kaovilai |
|
Should be able to run the ci |
|
I just approved aswell, there is the pending requests for review , @ywk253100 @sseago when you get a chance could we have a Quick Look at this small but needed change in order for this to work? |
|
Hello. Any news on this subject ? Thanks. |
7 participants
Currently AAD URI will throw an error with volume snapshotter, and in practice will cause volume snapshots to be attempted using DefaultAzureCredential when used with Azure, which causes failures in certain contexts. This should resolve that issue.