Skip to content

Fix volume snapshotter usage of AAD URI #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylanbossie-rise8 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix volume snapshotter usage of AAD URI #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19c18a0
Update volume_snapshotter.go
dylanbossie-rise8 Oct 22, 2024
1dffdf7
Add changelog
dylanbossie Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/unreleased/256-dylanbossie-rise8
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update volume_snapshotter to correctly use AAD URI which fixes behavior for Azure Workload Identities
Copy link
Copy Markdown
Contributor

@Jeremy-Boyle Jeremy-Boyle Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file @dylanbossie-rise8 , its automatically generated via commits, when a release is cut.

Copy link
Copy Markdown
Collaborator

@kaovilai kaovilai Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelogs/unreleased/ is not automatically generated at least for all other velero repos.

I suggests keeping the changelog here.

Copy link
Copy Markdown
Contributor

@Jeremy-Boyle Jeremy-Boyle Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelogs/unreleased/ is not automatically generated at least for all other velero repos.

I suggests keeping the changelog here.

Ah thanks ! I didn't notice that i just looked at some other commits and MRs good job @dylanbossie-rise8 for noticing that. Side, note did you have any further questions for above ?

1 change: 1 addition & 0 deletions velero-plugin-for-microsoft-azure/volume_snapshotter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ func newVolumeSnapshotter(logger logrus.FieldLogger) *VolumeSnapshotter {

func (b *VolumeSnapshotter) Init(config map[string]string) error {
if err := veleroplugin.ValidateVolumeSnapshotterConfigKeys(config,
vslConfigKeyActiveDirectoryAuthorityURI,
Comment thread
kaovilai marked this conversation as resolved.
vslConfigKeyResourceGroup,
vslConfigKeyAPITimeout,
vslConfigKeySubscriptionID,
Expand Down