fix: prevent browser.close() from killing external Chrome via CDP#661
Open
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: prevent browser.close() from killing external Chrome via CDP#661juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Conversation
When connected via `connectOverCDP()`, Playwright's `browser.close()` sends the CDP `Browser.close` command which terminates the external browser process. This happens both in the `connectViaCDP` error handler and in `BrowserManager.close()`. Fix: set `_shouldCloseConnectionOnClose = true` after connecting via CDP. This makes `.close()` only drop the WebSocket connection without sending the kill command, matching the behavior of `chromium.connect()`. Closes vercel-labs#539 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When connected via
connectOverCDP(), callingbrowser.close()sends the CDPBrowser.closecommand which terminates the external Chrome process. This happens both inconnectViaCDPerror handling and inBrowserManager.close().Root cause
Playwright's
connectOverCDP()sets_shouldCloseConnectionOnClose = falseby default, meaning.close()sends the CDP kill command rather than just dropping the WebSocket.Fix
Set
_shouldCloseConnectionOnClose = trueimmediately after connecting via CDP. This makes.close()only drop the WebSocket connection, matching the behavior ofchromium.connect().Single line fix that protects both call sites (
connectViaCDPcatch block andBrowserManager.close()CDP branch).Test plan
--cdp 9222, then close — Chrome stays alive--cdp 9222with invalid state — Chrome stays alive after errorCloses #539
🤖 Generated with Claude Code