Skip to content

fix: prevent browser.close() from killing external Chrome via CDP #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juliobrasa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent browser.close() from killing external Chrome via CDP #661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1531,6 +1531,10 @@ export class BrowserManager {
);
});

// Ensure close() only drops the WebSocket connection instead of sending
// the CDP Browser.close command which kills the external browser process.
(browser as any)._shouldCloseConnectionOnClose = true;

// Validate and set up state, cleaning up browser connection if anything fails
try {
const contexts = browser.contexts();
Expand Down