fix: prevent check/uncheck from hanging on hidden checkbox elements#665
Open
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: prevent check/uncheck from hanging on hidden checkbox elements#665juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Conversation
UI frameworks (Element UI, Ant Design, Vuetify) hide native checkbox inputs with `opacity: 0` and zero dimensions. Playwright's `check()` waits indefinitely for the element to become "actionable" — a condition that never satisfies for hidden inputs. Fix: attempt `check()`/`uncheck()` with a 5-second timeout first. If it fails (due to visibility/actionability), retry with `force: true` to bypass actionability checks. This handles both standard visible checkboxes and framework-hidden ones. Closes vercel-labs#335 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UI frameworks (Element UI, Ant Design, Vuetify) hide native
<input type="checkbox">withopacity: 0and zero dimensions. Playwright'scheck()waits indefinitely for actionability — a condition that never satisfies for hidden inputs.Fix
Attempt
check()/uncheck()with a 5-second timeout first. If it fails due to actionability, retry withforce: trueto bypass visibility checks. This handles both standard visible checkboxes and framework-hidden ones without changing behavior for normal cases.Test plan
checkworks on visible checkboxes (normal path)checkworks on hidden native checkboxes (force fallback)checkstill reports errors for non-existent selectorsCloses #335
🤖 Generated with Claude Code