Skip to content

fix: prevent check/uncheck from hanging on hidden checkbox elements #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juliobrasa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent check/uncheck from hanging on hidden checkbox elements #665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,19 +1136,30 @@ async function handleFill(command: FillCommand, browser: BrowserManager): Promis
async function handleCheck(command: CheckCommand, browser: BrowserManager): Promise<Response> {
const locator = browser.getLocator(command.selector);
try {
await locator.check();
} catch (error) {
throw toAIFriendlyError(error, command.selector);
await locator.check({ timeout: 5000 });
} catch {
// Retry with force for hidden checkboxes (common in UI frameworks like
// Element UI, Ant Design, Vuetify that hide native inputs with opacity:0)
try {
await locator.check({ force: true });
} catch (error) {
throw toAIFriendlyError(error, command.selector);
}
}
return successResponse(command.id, { checked: true });
}

async function handleUncheck(command: UncheckCommand, browser: BrowserManager): Promise<Response> {
const locator = browser.getLocator(command.selector);
try {
await locator.uncheck();
} catch (error) {
throw toAIFriendlyError(error, command.selector);
await locator.uncheck({ timeout: 5000 });
} catch {
// Retry with force for hidden checkboxes
try {
await locator.uncheck({ force: true });
} catch (error) {
throw toAIFriendlyError(error, command.selector);
}
}
return successResponse(command.id, { unchecked: true });
}
Expand Down