fix(ai): restore onFinish callback in ToolLoopAgent stream and generate methods#15823
Open
MaitreyeeDeshmukh wants to merge 2 commits into
Open
fix(ai): restore onFinish callback in ToolLoopAgent stream and generate methods#15823MaitreyeeDeshmukh wants to merge 2 commits into
MaitreyeeDeshmukh wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
PR #13698 accidentally removed
onFinishfromcallbackArgsin bothToolLoopAgent.stream()andToolLoopAgent.generate()while removing experimental callbacks.onFinishis a stable public API callback, not experimental — any handler passed to the agent was silently dropped after that change.What changed
Added
onFinish: mergeCallbacks(this.settings.onFinish, onFinish)back tocallbackArgsin both methods inpackages/ai/src/agent/tool-loop-agent.ts, immediately after the existingonStepFinishline.Testing
Added two regression tests to
tool-loop-agent.test.ts— one forgenerate()and one forstream()— verifyingonFinishis called on completion. All 103 tests pass locally.Closes #14330