Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-tool-loop-agent-on-finish.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ai": patch
---

fix(ai): restore onFinish callback in ToolLoopAgent stream and generate methods
32 changes: 32 additions & 0 deletions packages/ai/src/agent/tool-loop-agent.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,21 @@ describe('ToolLoopAgent', () => {
]);
});
});

it('should invoke onFinish when generation completes', async () => {
let onFinishCalled = false;

const agent = new ToolLoopAgent({ model: mockModel });

await agent.generate({
prompt: 'Hello, world!',
onFinish: async () => {
onFinishCalled = true;
},
});

expect(onFinishCalled).toBe(true);
});
});

describe('stream', () => {
Expand Down Expand Up @@ -1196,6 +1211,23 @@ describe('ToolLoopAgent', () => {
},
]);
});

it('should invoke onFinish when stream completes', async () => {
let onFinishCalled = false;

const agent = new ToolLoopAgent({ model: mockModel });

const result = await agent.stream({
prompt: 'Hello, world!',
onFinish: async () => {
onFinishCalled = true;
},
});

await result.consumeStream();

expect(onFinishCalled).toBe(true);
});
});

describe('experimental_onStart', () => {
Expand Down
2 changes: 2 additions & 0 deletions packages/ai/src/agent/tool-loop-agent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ export class ToolLoopAgent<
onToolExecutionEnd,
),
onStepFinish: mergeCallbacks(this.settings.onStepFinish, onStepFinish),
onFinish: mergeCallbacks(this.settings.onFinish, onFinish),
onEnd: mergeCallbacks(this.settings.onEnd, onEnd),
};

Expand Down Expand Up @@ -277,6 +278,7 @@ export class ToolLoopAgent<
onToolExecutionEnd,
),
onStepFinish: mergeCallbacks(this.settings.onStepFinish, onStepFinish),
onFinish: mergeCallbacks(this.settings.onFinish, onFinish),
onEnd: mergeCallbacks(this.settings.onEnd, onEnd),
};

Expand Down