-
Notifications
You must be signed in to change notification settings - Fork 412
Accurate Xilinx 7 series architecture #2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ions occuring on L shaped and stub wires. Updated arch has greatly improved min chanel width on larger designs (stereovision0 174->66 after changes).
@WhiteNinjaZ @jgoeders : I think this is the most recent 7-series capture. If it is, I think it would be good to merge into the master so we have an architecture (which can still be refined) on the master branch that is the current best capture. It would also be good to add a CI test or two targeting it to make sure it doesn't get broken. |
Yes this is the most up to date arch! |
@WhiteNinjaZ, @jgoeders : @MohamedElgammal and I are going through the VTR 9 paper and trying to make sure Mohamed's 7-series figure is accurate, and that the capture is fairly accurate.
|
@vaughnbetz In answer to your questions
|
Thanks for the fast and detailed answers @WhiteNinjaZ . That all makes sense. |
@WhiteNinjaZ : can this PR be merged? It has a couple of CI failures -- are they spurious? I think we need to get this merged ASAP. |
@vaughnbetz: I am putting the finishing touches on the last version of this architecture and should be done in the next few days. I believe the CI failures are spurious since this PR does not make any changes to the VTR code base and only adds a new architecture. |
OK, maybe you just need to rebase (golden results might have changed).
Even if it isn't perfect, I think we should merge this very soon (this
week).
Vaughn
…On Mon, Sep 30, 2024 at 12:22 PM Joshua Fife ***@***.***> wrote:
@vaughnbetz <https://github.com/vaughnbetz>: I am putting the finishing
touches on the last version of this architecture and should be done in the
next few days. I believe the CI failures are spurious since this PR does
not make any changes to the VTR code base and only adds a new architecture.
—
Reply to this email directly, view it on GitHub
<#2301 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNDPJ6P2ACTJHACIAOUV6TZZF3FHAVCNFSM6AAAAAAXTTQXRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTGY2DSNRUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
@vaughnbetz just pushed the most updated architecture: note that we are still running a few tests to try and figure out the weird increase in wirelength for the designs and if needed will make a few final changes to this architecture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested minor fixes to the comment at the top.
Also, the filename has a typo I think: cary should be carry
If you make these changes and remove the WIP we can merge this. |
@vaughnbetz This should be good to merge as soon as I add some tests. I will be able to do that tomorrow evening. A few notes: from the last major push of this architecture (from June) minW and wirelength have gone up by about 15% on average (the values collected for this version of the architecture have been updated in the vtr paper). The main culprit of this increase was more tightly spaced BRAM and DSP tiles in the earlier architecture and the fact that some of our FC override specifications for the CLB tile where actually never being implemented in the generated RR graph for the earlier arch version. |
Thanks @WhiteNinjaZ (and @jgoeders). We should merge this very soon .. the VTR paper is pretty close to done. We can talk about it today, but the 7-series arch is now one of a very small number of outstanding items, so we should merge this and close out that section ASAP. |
@vaughnbetz Sounds good. I'm out of town today and can't make the meeting, but it sounds like Joshua is done with the paper and just working on getting this PR through. I'll give our section another read through tomorrow to double check everything. |
Looks good. I also suggest adding a single small circuit (in another test suite) to vtr_reg_strong so it runs on the github runners, and is tested more frequently (even if the google CI is down). I'd make that one a fixed channel width run, again to keep the runtime low (and please post what the runtime is for that design). Ideally this would be a design that runs in seconds or tens of seconds. |
One failure, but it is a known problem with odd-even routing unit tests (@soheilshahrouz : please disable that one). Merging this and filing an issue for the strong (small circuit) test. |
Description
This PR provides the most up to date arch file for the Xilinx 7 series chip set. This PR is a WIP and is expected to change often.