create workbench-jupyter-docker devcontainer to support docker workflows #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerwangcs
approved these changes
Apr 18, 2025
| "service": "app", | ||
| "shutdownAction": "none", | ||
| "workspaceFolder": "/workspace", | ||
| "initializeCommand": "DOCKER_GID=`getent group docker | cut -d: -f3` && echo \"DOCKER_GID=${DOCKER_GID}\" > .env", |
There was a problem hiding this comment.
nit: comment explaining this init command?
| chown -R jupyter /home/jupyter/.docker | ||
|
|
||
| # Login to docker with gcloud credentials (needs to be re-run every 30 min if needed) | ||
| sudo -u jupyter /bin/bash -c "docker login -u oauth2accesstoken -p $(gcloud auth print-access-token) https://us-central1-docker.pkg.dev" |
There was a problem hiding this comment.
I can't remember why I chose the access token route. Gcp supports a number of other auth methods. If rerunning every 30 min is not desirable, we could experiment with gcloud credential helper https://cloud.google.com/artifact-registry/docs/docker/authentication
There was a problem hiding this comment.
IIRC we tried gcloud auth configure-docker but it was making changes to the docker config file within the container rather than in the host, so went with this approach instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports Docker out of Docker (DooD) by exposing the docker socket and running jupyter under the docker group.
Mostly #149 with some small changes from #163