Skip to content

create workbench-jupyter-docker devcontainer to support docker workflows #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions src/workbench-jupyter-docker/.devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
{
"name": "Workbench JupyterLab with docker support devcontainer template",
"dockerComposeFile": "docker-compose.yaml",
"service": "app",
"shutdownAction": "none",
"workspaceFolder": "/workspace",
// Get the host's docker group ID and propagate it into the .env file, which
// allows it to be used within docker-compose.yaml.
"initializeCommand": "DOCKER_GID=`getent group docker | cut -d: -f3` && echo \"DOCKER_GID=${DOCKER_GID}\" > .env",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: comment explaining this init command?

"postCreateCommand": "./startupscript/post-startup.sh jupyter /home/jupyter ${templateOption:cloud} ${templateOption:login} && ./startupscript/setup-docker.sh",
// re-mount bucket files on container start up
"postStartCommand": [
"./startupscript/remount-on-restart.sh",
"jupyter",
"/home/jupyter",
"${templateOption:cloud}",
"${templateOption:login}"
],
"remoteUser": "root",
"customizations": {
"workbench": {
"opens": {
"extensions": [
// Source
".ipynb",
".R",
".py",
// Documents
".md",
".html",
".latex",
".pdf",
// Images
".bmp",
".gif",
".jpeg",
".jpg",
".png",
".svg",
// Data
".csv",
".tsv",
".json",
".vl"
],
"fileUrlSuffix": "/lab/tree/{path}",
"folderUrlSuffix": "/lab/tree/{path}"
}
}
}
}
17 changes: 17 additions & 0 deletions src/workbench-jupyter-docker/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@

# Custom Workbench JupyterLab App Template (workbench-jupyter-docker)

A template used to serve the Workbench custom JupyterLab app.

## Options

| Options Id | Description | Type | Default Value |
|-----|-----|-----|-----|
| cloud | VM cloud environment | string | gcp |
| login | Whether to log in to workbench CLI | string | false |



---

_Note: This file was auto-generated from the [devcontainer-template.json](devcontainer-template.json). Add additional notes to a `NOTES.md`._
23 changes: 23 additions & 0 deletions src/workbench-jupyter-docker/devcontainer-template.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"id": "custom-workbench-jupyter-template",
"description": "A template used to serve the Workbench JupyterLab container image",
"version": "0.0.1",
"name": "Workbench Prebuilt JupyterLab Template",
"documentationURL": "https://github.com/verily-src/workbench-app-devcontainers/tree/master/src/custom-workbench-jupyter-template",
"licenseURL": "https://github.com/verily-src/workbench-app-devcontainers/blob/master/LICENSE",
"options": {
"cloud": {
"type": "string",
"description": "VM cloud environment",
"proposals": ["gcp", "aws"],
"default": "gcp"
},
"login": {
"type": "string",
"description": "Whether to log in to workbench CLI",
"proposals": ["true", "false"],
"default": "false"
}
},
"platforms": ["Any"]
}
28 changes: 28 additions & 0 deletions src/workbench-jupyter-docker/docker-compose.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
version: "2.4"
services:
app:
container_name: "application-server"
image: "us-central1-docker.pkg.dev/verily-workbench-public/apps/workbench-jupyter:latest"
user: "jupyter:${DOCKER_GID}"
restart: always
volumes:
- .:/workspace:cached
# mount Host machine's docker.sock to container's docker.sock
- /var/run/docker.sock:/var/run/docker.sock
# mount Host machine's /etc/group to container's /etc/host-group
- /etc/group:/etc/host-group
# mount Host machine's default docker config dir to container's jupyter user docker config dir
- /etc/docker:/home/jupyter/.docker
ports:
- "8888:8888"
networks:
- app-network
cap_add:
- SYS_ADMIN
devices:
- /dev/fuse
security_opt:
- apparmor:unconfined
networks:
app-network:
external: true
45 changes: 45 additions & 0 deletions startupscript/setup-docker.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
#!/bin/bash
# setup-docker.sh
# Installs the docker CLI and configure the host machine's docker group to
# include the app container user.

set -o errexit
set -o nounset
set -o pipefail
set -o xtrace

######################
# Install Docker CLI #
######################

mkdir -p /etc/apt/keyrings && \
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | gpg --dearmor -o /etc/apt/keyrings/docker.gpg && \
echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null && \

apt-get update && \
apt-get install -y docker-ce-cli && \

###########################################
# Add container user to host docker group #
###########################################

# Add jupyter user to the host's docker group
sed "/^docker:/ s/$/,jupyter/" /etc/host-group > /tmp/host-group.modified
tee /etc/host-group < /tmp/host-group.modified > /dev/null

# create a matching docker group in the container and add the user to it
DOCKER_GID=$(grep '^docker:' "/etc/host-group" | cut -d: -f3)
if ! getent group docker; then
groupadd -g "$DOCKER_GID" docker
fi
usermod -aG docker jupyter

###########################
# Configuring docker auth #
###########################

# Give user write permissions to the mounted docker config directory
chown -R jupyter /home/jupyter/.docker

# Login to docker with gcloud credentials (needs to be re-run every 30 min if needed)
sudo -u jupyter /bin/bash -c "docker login -u oauth2accesstoken -p $(gcloud auth print-access-token) https://us-central1-docker.pkg.dev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember why I chose the access token route. Gcp supports a number of other auth methods. If rerunning every 30 min is not desirable, we could experiment with gcloud credential helper https://cloud.google.com/artifact-registry/docs/docker/authentication

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we tried gcloud auth configure-docker but it was making changes to the docker config file within the container rather than in the host, so went with this approach instead