Deprecate coremodules (SYN-8048) #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4188 +/- ##
==========================================
- Coverage 97.35% 97.28% -0.08%
==========================================
Files 261 261
Lines 59870 59872 +2
==========================================
- Hits 58288 58247 -41
- Misses 1582 1625 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vEpiphyte
reviewed
Mar 20, 2025
synapse/cortex.py
Outdated
|
|
||
| coremods = self.conf.get('modules') | ||
| if coremods is not None: | ||
| mesg = "The 'modules' Cortex config value is deprecated and will be removed in v3.0.0." |
There was a problem hiding this comment.
Can we avoid warning on the synapse.tests.utils.TestModule being present so we aren't warning for every test cortex we spin up?
There was a problem hiding this comment.
Updated to skip warning on any synapse.tests modules
vEpiphyte
reviewed
Mar 20, 2025
vEpiphyte
reviewed
Mar 28, 2025
vEpiphyte
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.