fix(CI): ensure we get a SHA for a container, or fail out if we do not [MERGEOK]#37184
Merged
Conversation
esolitos
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the Buildkite container publish step by validating that crane digest actually returns an image digest before proceeding to signing/metadata, avoiding silent progression when the digest output is empty.
Changes:
- Add an explicit post-
crane digestguard for the Vespa preview container publish/sign step. - Align the system-test container digest guard with the same early-fail behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The empty-string check uses a non-idiomatic ${IMAGE_SHA256}na trick, which is harder to read/maintain than Bash’s built-in -z test. Using [[ -z ... ]] is clearer.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
esolitos
added
the
reviewer can merge
arnej27959
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.