-
Notifications
You must be signed in to change notification settings - Fork 34
feat: add snapshot-controller #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
09f30f4 to
60ea552
Compare
Signed-off-by: Tadas Sutkaitis <[email protected]> Signed-off-by: Tadas Sutkaitis <[email protected]>
60ea552 to
6d38505
Compare
okozachenko1203
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update dependency projectcalico/calico to v3.30.1 Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: apply pre-commit hook updates --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update dependency projectcalico/calico to v3.30.2 Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: apply pre-commit hook updates --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#732) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* doc: update about images Signed-off-by: okozachenko1203 <[email protected]> * remove duplicated contents in readme Signed-off-by: okozachenko1203 <[email protected]> * Update images.md --------- Signed-off-by: okozachenko1203 <[email protected]> Co-authored-by: okozachenko1203 <[email protected]> Co-authored-by: Mohammed Naser <[email protected]>
kubernetes-sigs/cluster-api@afd68cd this is a pre-req change to upgrade CAPI to v1.10 Signed-off-by: okozachenko1203 <[email protected]>
* Upgrade capi version Signed-off-by: okozachenko1203 <[email protected]> * upgrade capi version to 1.10.5 --------- Signed-off-by: okozachenko1203 <[email protected]> Co-authored-by: Mohammed Naser <[email protected]>
* fix: default autoscaler image to .0 instead of hardcoding autoscaler images, we can simply assume .0 release exists for the requested version instead of full on failing. Signed-off-by: Mohammed Naser <[email protected]> * ci: add automation to keep cluster-autoscaler updated Signed-off-by: Mohammed Naser <[email protected]> * fix: enable cloud-provider option <1.29.0 Signed-off-by: Mohammed Naser <[email protected]> * chore: remove unused get_image functions Signed-off-by: Mohammed Naser <[email protected]> * fix: remove unused autoscaler options Signed-off-by: Mohammed Naser <[email protected]> * fix: remove cloud-provider only after 1.33 Signed-off-by: Mohammed Naser <[email protected]> --------- Signed-off-by: Mohammed Naser <[email protected]>
* ci: add automation for k8s version bump Signed-off-by: Mohammed Naser <[email protected]> * ci: use latest release images from capo-image-elements Signed-off-by: Mohammed Naser <[email protected]> * add gh cli Signed-off-by: Mohammed Naser <[email protected]> * ✨ chore: replace setup-gh action with install-gh-cli-action Signed-off-by: Mohammed Naser <[email protected]> * 🔧 chore: specify gh-cli version in CI workflow Signed-off-by: Mohammed Naser <[email protected]> * 🔧 chore: add GH_TOKEN environment variable for authentication Signed-off-by: Mohammed Naser <[email protected]> * 🔧 chore: update jq filter for kubernetes version in CI workflow Signed-off-by: Mohammed Naser <[email protected]> --------- Signed-off-by: Mohammed Naser <[email protected]>
* Add ability to set admission control plugins Signed-off-by: Kris Lindgren <[email protected]> * Fix tests and remove empty admission_plugin test Signed-off-by: Kris Lindgren <[email protected]> --------- Signed-off-by: Kris Lindgren <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Added GH_TOKEN environment variable for cluster-autoscaler script.
…#763) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
| with: | ||
| token: ${{ secrets.VEXXHOST_BOT_PAT }} | ||
| - run: ./hack/bump/kubernetes.sh | ||
| - uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e # v7.0.8 | ||
| with: | ||
| token: ${{ secrets.VEXXHOST_BOT_PAT }} | ||
| commit-message: "chore(deps): update kubernetes" | ||
| signoff: true | ||
| title: "chore(deps): update kubernetes" | ||
| body: | | ||
| ## Automated Kubernetes Version Update | ||
| This PR updates the Kubernetes versions in the CI workflow to the latest maintained versions. | ||
| Source: https://endoflife.date/kubernetes | ||
| delete-branch: true | ||
| branch: bump/kubernetes | ||
|
|
||
| cluster-autoscaler: |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 months ago
The optimal way to fix the issue is to add an explicit permissions block to the workflow, at the top level (so it applies to all jobs by default), restricting the GITHUB_TOKEN to the least privilege. Since both jobs use the actions/checkout and peter-evans/create-pull-request actions, and the PR creation is done via a custom token (not GITHUB_TOKEN), only read access to git contents is required. Therefore, set permissions: contents: read at the root workflow level (just after the workflow name:), unless there are steps that require more permissions using the GITHUB_TOKEN (none seem present).
Changes needed:
- In
.github/workflows/bump.yml, insert apermissions:block after thename: bumpline, with at leastcontents: read. - No additional packages or methods are required for this change.
-
Copy modified lines R1-R2
| @@ -1,3 +1,5 @@ | ||
| permissions: | ||
| contents: read | ||
| name: bump | ||
|
|
||
| on: |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
| with: | ||
| token: ${{ secrets.VEXXHOST_BOT_PAT }} | ||
| - run: ./hack/bump/cluster-autoscaler.sh | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| - uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e # v7.0.8 | ||
| with: | ||
| token: ${{ secrets.VEXXHOST_BOT_PAT }} | ||
| commit-message: "chore(deps): update cluster-autoscaler" | ||
| signoff: true | ||
| title: "chore(deps): update cluster-autoscaler" | ||
| body: | | ||
| ## Automated `cluster-autoscaler` update | ||
| This PR updates the `cluster-autoscaler` images to the latest versions. | ||
| delete-branch: true | ||
| branch: bump/cluster-autoscaler |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 months ago
To fix the issue, add a permissions key to the workflow file. This block can be added either at the root level (applying to all jobs) or at the individual job level. Since both jobs in this workflow perform actions requiring repository access (checkout, create-pull-request, etc.), but only limited permissions are necessary, the block should grant only what is strictly required: contents: write (for pushing branches, committing to repository), and pull-requests: write (to create and update PRs). Some actions may work with less, but the two used here often require these permissions. Insert the following block after the workflow name on line 2:
permissions:
contents: write
pull-requests: writeNo method imports or external definitions are required.
-
Copy modified lines R1-R3
| @@ -1,3 +1,6 @@ | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| name: bump | ||
|
|
||
| on: |
Solves: #117
Some answers to obvious questions: