feat: enable snapshot-controller and add custom helm chart #795
Conversation
Signed-off-by: Tadas Sutkaitis <[email protected]>
fitbeard
force-pushed
the
feat/csi_snapshot_controller_helm
branch
2 times, most recently
from
2883775 to
8c5b2be
Compare
Signed-off-by: Tadas Sutkaitis <[email protected]>
fitbeard
force-pushed
the
feat/csi_snapshot_controller_helm
branch
from
8c5b2be to
62459f3
Compare
Signed-off-by: Tadas Sutkaitis <[email protected]>
Signed-off-by: Tadas Sutkaitis <[email protected]>
fitbeard
force-pushed
the
feat/csi_snapshot_controller_helm
branch
from
34b040f to
61d2675
Compare
|
@mnaser just a highlight:) |
| # Add snapshot controller CSI chart if either Cinder CSI or Manila CSI is enabled. | ||
| if cinder.is_enabled(self.cluster) or manila.is_enabled(self.cluster): | ||
|
|
||
| # Build volume snapshot classes based on enabled CSI drivers. | ||
| volume_snapshot_classes = [] | ||
|
|
||
| # Add Cinder CSI volume snapshot class if enabled. | ||
| if cinder.is_enabled(self.cluster): | ||
| volume_snapshot_classes.append( | ||
| { | ||
| "name": "block-snapshot", | ||
| "annotations": { | ||
| "snapshot.storage.kubernetes.io/is-default-class": "true" | ||
| }, | ||
| "driver": "cinder.csi.openstack.org", | ||
| "deletionPolicy": "Delete", | ||
| } | ||
| ) | ||
|
|
||
| # Add Manila CSI volume snapshot class if enabled and share_network_id is specified. | ||
| if manila.is_enabled(self.cluster): | ||
| share_network_id = self.cluster.labels.get( | ||
| "manila_csi_share_network_id" | ||
| ) | ||
| if share_network_id: | ||
| volume_snapshot_classes.append( | ||
| { | ||
| "name": "share-snapshot", | ||
| "annotations": { | ||
| "snapshot.storage.kubernetes.io/is-default-class": "true" | ||
| }, | ||
| "driver": "nfs.manila.csi.openstack.org", | ||
| "deletionPolicy": "Delete", | ||
| "parameters": { | ||
| "csi.storage.k8s.io/snapshotter-secret-name": "csi-manila-secrets", | ||
| "csi.storage.k8s.io/snapshotter-secret-namespace": "kube-system", | ||
| }, | ||
| } | ||
| ) | ||
|
|
||
| controller_values = { | ||
| "fullnameOverride": "snapshot-controller", | ||
| "volumeSnapshotClasses": volume_snapshot_classes, | ||
| } | ||
|
|
||
| # Override image repository if custom registry is configured | ||
| if repository: # repository is the container_infra_prefix | ||
| repository_clean = repository.rstrip("/") | ||
| # When using a custom registry, the image is named 'csi-snapshot-controller' | ||
| controller_values["image"] = { | ||
| "repository": f"{repository_clean}/csi-snapshot-controller" | ||
| } | ||
| # For default registry, use the default image name 'snapshot-controller' from values.yaml | ||
|
|
||
| data = { | ||
| **data, | ||
| **{ | ||
| "snapshot-controller-csi.yaml": helm.TemplateReleaseCommand( | ||
| namespace="kube-system", | ||
| release_name="snapshot-controller", | ||
| chart_ref=os.path.join( | ||
| pkg_resources.resource_filename( | ||
| "magnum_cluster_api", "charts" | ||
| ), | ||
| "snapshot-controller-csi/", | ||
| ), | ||
| values={"controller": controller_values}, | ||
| )(repository=repository) | ||
| }, | ||
| } | ||
|
|
There was a problem hiding this comment.
A lot of this code has been moved to the Rust counterpart, so probably best to move forward with putting it there.
There was a problem hiding this comment.
Please show me where to start looking.
There was a problem hiding this comment.
This code should probably not be maintained as much since we have another Rust counterpart that is being used.
There was a problem hiding this comment.
With the rust side of things, there is another way of configuring the images.
There was a problem hiding this comment.
? This is for internal path for offline registry.
There was a problem hiding this comment.
There was a problem hiding this comment.
Actually this is 95% copy of this chart. There is no official chart for snapshot-controller so community is trying to cover this gap. If we ok to use third party helm charts then i can try to push few small changes to this mentioned repo and use this chart.
There was a problem hiding this comment.
Let's do that if you don't mind, it's probably best for the community and help with maintenance overhead :)
Second attempt to impement Snapshot Controller: #117
For reference first is here: #731