Add basic reverse-mode custom derivatives for STL iterators - #1437
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| template <class T> | ||
| struct is_iterator< | ||
| T, typename ::std::enable_if<!::std::is_same< | ||
| typename ::std::iterator_traits<T>::value_type, void>::value>::type> |
Contributor
There was a problem hiding this comment.
warning: use c++14 style type templates [modernize-type-traits]
Suggested change
| typename ::std::iterator_traits<T>::value_type, void>::value>::type> | |
| T, ::std::enable_if_t<!::std::is_same< | |
| typename ::std::iterator_traits<T>::value_type, void>::value>> |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
arima-04
force-pushed
the
IteratorsCustomDerivatives
branch
3 times, most recently
from
July 5, 2025 18:15
6cc140d to
7db8bc4
Compare
This commit adds basic reverse-mode custom derivatives for STL iterators. More specifically, the commit adds the below custom derivatives: - operator_star_reverse_forw for iterators - constructor_reverse_forw for iterators - operator_plus_plus_reverse_forw and operator_plus_plus_pullback for iterators Closes vgvassilev#751
arima-04
force-pushed
the
IteratorsCustomDerivatives
branch
from
July 5, 2025 18:37
7db8bc4 to
9a43650
Compare
Collaborator
|
This now fails on master. |
PetroZarytskyi
added a commit
to PetroZarytskyi/clad
that referenced
this pull request
Jul 6, 2025
…t the same time. This PR addresses 2 problems that arose after that: a mismatch in the signature of a new custom `reverse_forw` and a new tape popping up in a test.
vgvassilev
pushed a commit
that referenced
this pull request
Jul 6, 2025
This PR addresses 2 problems that arose after that: a mismatch in the signature of a new custom `reverse_forw` and a new tape popping up in a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds basic reverse-mode custom derivatives for STL iterators. More specifically, the commit adds the below custom derivatives:
Closes #751