Schedule reverse_forw functions statically - #1438
Merged
Merged
Conversation
Before this commit, generated functions were labeled `_forw` and the custom ones `_reverse_forw`. Now, all of them are labeled `_reverse_forw`.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Before this PR, all `reverse_forw` functions were scheduled only dynamically. Now, they are always scheduled statically.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
PetroZarytskyi
added a commit
to PetroZarytskyi/clad
that referenced
this pull request
Jul 6, 2025
…t the same time. This PR addresses 2 problems that arose after that: a mismatch in the signature of a new custom `reverse_forw` and a new tape popping up in a test.
vgvassilev
pushed a commit
that referenced
this pull request
Jul 6, 2025
This PR addresses 2 problems that arose after that: a mismatch in the signature of a new custom `reverse_forw` and a new tape popping up in a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, all
reverse_forwfunctions were scheduled only dynamically. Now, they are always scheduled statically. Also, before the PR, generated functions were labeled_forwand the custom ones_reverse_forw. Now, all of them are labeled_reverse_forw.Note: For now,
constructor_reverse_forware still scheduled dynamically because their signature is different from otherreverse_forw: they have an extra parameterConstructorReverseForwTag. We should probably consider removing.