Skip to content

DOCS-3642: Update optional dependencies #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 23, 2025

Conversation

JessamyT
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented May 16, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit c2f5c5a
🔍 Latest deploy log https://app.netlify.com/projects/viam-docs/deploys/6830a9e8109ded0008191e0c
😎 Deploy Preview https://deploy-preview-4309--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 42 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label May 16, 2025
@JessamyT JessamyT force-pushed the 3642optionaldeps branch from b590c18 to 2494078 Compare May 22, 2025 05:07
@JessamyT JessamyT marked this pull request as ready for review May 22, 2025 05:07
@JessamyT JessamyT requested a review from benjirewis May 22, 2025 05:13
Copy link
Member

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much LGTM; thanks!

Comment on lines 182 to 184
If an optional dependency does not start, the module will continue to build and reconfigure without it.
`viam-server` reattempts to construct the optional dependency every 5 seconds.
When an optional dependency constructs successfully, your modular resource reconfigures so it can access the optional dependency.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjirewis is this good/accurate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me! Left one more suggestion.

Comment on lines 182 to 184
If an optional dependency does not start, the module will continue to build and reconfigure without it.
`viam-server` reattempts to construct the optional dependency every 5 seconds.
When an optional dependency constructs successfully, your modular resource reconfigures so it can access the optional dependency.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me! Left one more suggestion.

Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

@JessamyT JessamyT merged commit 4fd8df4 into viamrobotics:main May 23, 2025
12 checks passed
@JessamyT JessamyT deleted the 3642optionaldeps branch May 23, 2025 17:05
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants