-
Notifications
You must be signed in to change notification settings - Fork 47
DOCS-3642: Update optional dependencies #4309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
b590c18
to
2494078
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much LGTM; thanks!
If an optional dependency does not start, the module will continue to build and reconfigure without it. | ||
`viam-server` reattempts to construct the optional dependency every 5 seconds. | ||
When an optional dependency constructs successfully, your modular resource reconfigures so it can access the optional dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjirewis is this good/accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me! Left one more suggestion.
If an optional dependency does not start, the module will continue to build and reconfigure without it. | ||
`viam-server` reattempts to construct the optional dependency every 5 seconds. | ||
When an optional dependency constructs successfully, your modular resource reconfigures so it can access the optional dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me! Left one more suggestion.
Co-authored-by: Benjamin Rewis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nit
🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs' |
No description provided.